Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103840
MIME-Version: 1.0
References: <CACDmYyeq6rzYb2zN6Gi2Yftn__m7WcS7dCrAJECfn8dsfc=ybw@mail.gmail.com>
 <CAF+90c8Cou_a9Pentwko7cf1jnKtkfAhWEB1AsHzKfTQ83JMsg@mail.gmail.com> <CACDmYyePVHhk0XFBqVYXmw6sHQFbu9aO8QLTOBwR8Eo7v5fvSw@mail.gmail.com>
In-Reply-To: <CACDmYyePVHhk0XFBqVYXmw6sHQFbu9aO8QLTOBwR8Eo7v5fvSw@mail.gmail.com>
Date: Thu, 24 Jan 2019 16:47:32 +0100
Message-ID: <CAF+90c9cLcEm2a6GWvoBY9e=EcOVHo4YEsgm=XtQ-u6-_qj=wg@mail.gmail.com>
To: Legale Legage <legale.legale@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e4e8ce0580362121"
Subject: Re: [PHP-DEV] mbstring unused internal functions
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000e4e8ce0580362121
Content-Type: text/plain; charset="UTF-8"

On Thu, Jan 24, 2019 at 4:17 PM Legale Legage <legale.legale@gmail.com>
wrote:

> Haven't checked php_mbregex.c
>
> This one is defined in mbstring.h but not exists in mbstring.c:
> php_mb_check_encoding_list()
>

Thanks, dropped in
https://github.com/php/php-src/commit/24085b187a7505aacb5bd76372f1522226656dd3
.


> These are not used anywhere within php-src dir:
> php_mb_mbchar_bytes()
> php_mb_safe_strrchr()
>

The _ex versions are used though, so it probably doesn't make much sense to
drop these.


> I think something wrong with php_mb_mbchar_bytes_ex()
> As far as i understand the function returns the character length in
> bytes based on the character encoding. At least for the UTF-16,
> UTF-16BE,UTF-16LE encodings it returns 1 but should return 2 or 4.
>

I agree that this function looks really fishy. It correctly handles UTF-8
and fixed-width encodings, but for everything else it always returns a
character width of 1, which doesn't make much sense.

Nikita

On Thu, Jan 24, 2019, 15:45 Nikita Popov <nikita.ppv@gmail.com wrote:
> >
> > On Thu, Jan 24, 2019 at 12:21 PM Legale Legage <legale.legale@gmail.com>
> wrote:
> >>
> >> Hello.
> >>
> >> Looking through the source code of the mbstring.c file I found a lot
> >> of unused internal functions. It seems that this is just a bunch of
> >> old junk.
> >>
> >> Examples:
> >>
> >> MBSTRING_API size_t php_mb_mbchar_bytes_ex(const char *s, const
> >> mbfl_encoding *enc)
> >> MBSTRING_API size_t php_mb_mbchar_bytes(const char *s)
> >> MBSTRING_API char *php_mb_safe_strrchr(const char *s, unsigned int c,
> >> size_t nbytes)
> >> MBSTRING_API char *php_mb_safe_strrchr_ex(const char *s, unsigned int
> >> c, size_t nbytes, const mbfl_encoding *enc)
> >
> >
> > How did you determine that these are unused? I'm seeing uses for all of
> them in mbstring.c or php_mbregex.c
> >
> > Nikita
>

--000000000000e4e8ce0580362121--