Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103831
MIME-Version: 1.0
References: <CACDmYyeq6rzYb2zN6Gi2Yftn__m7WcS7dCrAJECfn8dsfc=ybw@mail.gmail.com>
In-Reply-To: <CACDmYyeq6rzYb2zN6Gi2Yftn__m7WcS7dCrAJECfn8dsfc=ybw@mail.gmail.com>
Date: Thu, 24 Jan 2019 15:45:19 +0100
Message-ID: <CAF+90c8Cou_a9Pentwko7cf1jnKtkfAhWEB1AsHzKfTQ83JMsg@mail.gmail.com>
To: Legale Legage <legale.legale@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006a5ca205803543b4"
Subject: Re: [PHP-DEV] mbstring unused internal functions
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000006a5ca205803543b4
Content-Type: text/plain; charset="UTF-8"

On Thu, Jan 24, 2019 at 12:21 PM Legale Legage <legale.legale@gmail.com>
wrote:

> Hello.
>
> Looking through the source code of the mbstring.c file I found a lot
> of unused internal functions. It seems that this is just a bunch of
> old junk.
>
> Examples:
>
> MBSTRING_API size_t php_mb_mbchar_bytes_ex(const char *s, const
> mbfl_encoding *enc)
> MBSTRING_API size_t php_mb_mbchar_bytes(const char *s)
> MBSTRING_API char *php_mb_safe_strrchr(const char *s, unsigned int c,
> size_t nbytes)
> MBSTRING_API char *php_mb_safe_strrchr_ex(const char *s, unsigned int
> c, size_t nbytes, const mbfl_encoding *enc)
>

How did you determine that these are unused? I'm seeing uses for all of
them in mbstring.c or php_mbregex.c

Nikita

--0000000000006a5ca205803543b4--