Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103800
MIME-Version: 1.0
References: <CAFPFaM+cEa2xFDqvkLQk=Qht3KdcGUCBaCj6JcuQxqLmjnf9Pw@mail.gmail.com>
 <HE1P189MB0492D67D4A6715B4FBF72F1A91990@HE1P189MB0492.EURP189.PROD.OUTLOOK.COM>
 <CAL0xaBH3OioafrCDMaRaHB1Z_Or81cLWZSrdL2LkW_SBTCG-3Q@mail.gmail.com>
 <CAFPFaMK++96wFq_cUVdPxQKKr5Tqsjyife6nvEHCSuvXwDH7Cg@mail.gmail.com> <C268C91D-D1EA-4096-BF97-0A56089907A8@gmail.com>
In-Reply-To: <C268C91D-D1EA-4096-BF97-0A56089907A8@gmail.com>
Date: Wed, 23 Jan 2019 15:53:18 +0100
Message-ID: <CAFPFaMJB=znh+SpjKtfaoGBt=Y9Ggo1VMXkUPF2zUsGVGvoEVw@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: Arvids Godjuks <arvids.godjuks@gmail.com>, Jani Ollikainen <jani.ollikainen@valve.fi>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e992ae05802141ed"
Subject: Re: [PHP-DEV] Deprecation ideas for PHP 8
From: george.banyard@gmail.com (Girgias)

--000000000000e992ae05802141ed
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 23 Jan 2019 at 15:43, Claude Pache <claude.pache@gmail.com> wrote:

> So, since you didn=E2=80=99t see, here are some practical usages of setty=
pe():
>
> <?php
> function foo($bar) {
>     // $bar is supposed to be either a string, or a list of strings
>     settype($bar, 'array');
>     // ...
> }
>
> function qux($id) {
>      if (!(is_int($id) || is_string($id) && ctype_digit($id)))
>         throw new \TypeError;
>     settype($id, 'int');
>     // ...
> }
>
> class Foo implements SeekableIterator {
>     function seek(/* int */ $position): void {
>         // NOTE: we cannot use int typehint here, because PHP7.1 requires
> mixed
>         settype($position, 'int');
>         // ...
>     }
> }
> ?>
>

All these examples could very well use a typecast and or one of the *val
functions


> Here are a usage of settype() with a non-constant second parameter: Defin=
e
> a utility function that cast a value to a given type when it is not null:
>
> <?php
> function cast_opt($val, $type) {
>     if ($val !=3D=3D null)
>         settype($val, $type);
>     return $val;
> }
>
> $foo =3D cast_opt($bar, 'int') // equivalent to: $foo =3D $bar =3D=3D=3D =
null ? null
> : (int) $bar;
> ?>
>
> Sure, one can avoid settype() and do it the complicated way, but why? Wha=
t
> is the issue with settype(), so that you want to deprecate it?
>

You didn't necessarely need to specify an example with a non-constant
second parameter
because you already gave valid arguments as why not to deprecate it, just
that I didn't see
them. I do appreciate the example however.

Why I want*ed* to deprecate is because I personally didn't see any usage
before,
you provided a valid usage and I don't see the point of deprecating it
anymore.
Maybe that wasn't clear from my previous reply. Because indeed removing
settype
brings back the same issue that I raised with gettype.
As it currently stands the only way I can see how settype can possibly be
deprecated
is ih PHP introduces a ReflectionVar classe which, like said in my initial
email, seems
like total overkill when a simple function exists.


Hope this clears everything up

Best regards

George P. Banyard

--000000000000e992ae05802141ed--