Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103747
To: Zeev Suraski <zeev@zend.com>
Cc: PHP internals <internals@lists.php.net>
References: <c23ebee1-3c11-0a2c-e390-578f166ab3d8@gmx.de>
 <E0B6A528-801B-4D88-9FD7-5FAF45665A0D@zend.com>
Message-ID: <628ac24b-71ca-5781-8e48-e5d63646e426@gmx.de>
Date: Tue, 15 Jan 2019 14:29:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <E0B6A528-801B-4D88-9FD7-5FAF45665A0D@zend.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Suggested libgd ABI change leading to ext/gd BC break
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 15.01.2019 at 13:32, Zeev Suraski wrote:

>> On 15 Jan 2019, at 13:13, Christoph M. Becker <cmbecker69@gmx.de> wrote:
>>
>> Most recently, a pull request has been submitted for libgd[1], which
>> suggests to define image IO functions for several image formats
>> unconditionally; if the format is not supported, the IO functions would
>> fail with an error notice.  This would break the current ext/gd
>> configuration, since it relies on checks for the existence of these
>> functions[2] to define the respective PHP functions conditionally and
>> for introspection (e.g. gd_info()).  In other words, building ext/gd
>> against the PR would define imagecreatefromweb() even if WebP is not
>> supported.  This would break code relying on `if
>> (function_exists('imagecreatefromweb'))` or such.
> 
> Given this downside, what is the upside of introducing this change?

Basically, to be able to switch libgd.so without recompiling its
clients, see
<https://github.com/libgd/libgd/issues/345#issuecomment-454148489>.  Of
course, that wouldn't work for ext/gd as it is now, but that is a
different story.  We have to deal with whatever the libgd developers decide.

-- 
Christoph M. Becker