Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103743
To: PHP internals <internals@lists.php.net>
Message-ID: <c23ebee1-3c11-0a2c-e390-578f166ab3d8@gmx.de>
Date: Tue, 15 Jan 2019 12:13:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Suggested libgd ABI change leading to ext/gd BC break
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi!

Most recently, a pull request has been submitted for libgd[1], which
suggests to define image IO functions for several image formats
unconditionally; if the format is not supported, the IO functions would
fail with an error notice.  This would break the current ext/gd
configuration, since it relies on checks for the existence of these
functions[2] to define the respective PHP functions conditionally and
for introspection (e.g. gd_info()).  In other words, building ext/gd
against the PR would define imagecreatefromweb() even if WebP is not
supported.  This would break code relying on `if
(function_exists('imagecreatefromweb'))` or such.

We would have to change ext/gd/config.m4 accordingly to keep BC (we
could either rely on gdSupportsFileType() or actually call the functions
checking for the error message during build-time).  However, I wonder
about stable PHP versions, and particularly PHP 7.1 which is supposed to
receive only security updates.  If the libgd PR will be merged and
released with libgd 2.3.0 which may well happen during this year,
unmodified PHP versions would break BC if built against libgd 2.3.0.

Suggestions how to deal with this are welcome!

[1] <https://github.com/libgd/libgd/pull/491>
[2]
<https://github.com/php/php-src/blob/php-7.3.1/ext/gd/config.m4#L217-L225>

-- 
Christoph M. Becker