Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103742
MIME-Version: 1.0
References: <CAF+90c-V9vG8eAanQgujb+GhkLWtH2N0VRe500oocNQ7ryfb=Q@mail.gmail.com>
 <CADyq6s+qnFfZGMfr0HfyW6Qu9MC+_M_h3mQDOiDMJzWWTVHE-Q@mail.gmail.com> <CAF+90c8u0Qn2+xJBpae+7YGBSXeaw_7RdZ6Ym7Q_R48ZWA7pLQ@mail.gmail.com>
In-Reply-To: <CAF+90c8u0Qn2+xJBpae+7YGBSXeaw_7RdZ6Ym7Q_R48ZWA7pLQ@mail.gmail.com>
Date: Tue, 15 Jan 2019 12:07:31 +0100
Message-ID: <CADyq6sLhJSBXAccYWRCV0TYjiG86E9_6OShFiRsCgJ-LsqS_RQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ac9a0f057f7d2bdb"
Subject: Re: [PHP-DEV] [RFC] Reflection for references
From: ocramius@gmail.com (Marco Pivetta)

--000000000000ac9a0f057f7d2bdb
Content-Type: text/plain; charset="UTF-8"

On Tue, Jan 15, 2019 at 11:57 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

>
>  * instead of `$ref1->getId() === $ref2->getId()`, `$ref1->matches($ref2)`
>> or such.
>>
>  * what are possible scenarios for getting the identifier as a primitive,
>> and then storing it somewhere (like an array of reference identifiers)?
>>
>  * There seems to be a lot of design around `ReflectionReference#getId()`
>> to avoid leaking internal pointer information: can it be completely
>> dropped, if we have `$ref1->matches($ref2)` instead?
>>
>
> As Nicolas already wrote, the ID / Hash functionality is needed to allow
> hashtable lookups. Having just matches() would require iterating over the
> whole set of known references and comparison each and every one. With the
> getId() API, it's just a single HT lookup.
>
> We could add $ref1->equals($ref2) as an *additional* convenience method,
> but it would not replace the getId() API.
>

I'd say that if the indexing is a fairly common scenario (seems like it,
coming from Nicolas, who is the most direct API consumer here), the
`->matches()` isn't needed at all.


Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--000000000000ac9a0f057f7d2bdb--