Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103721
Return-Path: <legale.legale@gmail.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 7685 invoked from network); 13 Jan 2019 18:54:07 -0000
Received: from unknown (HELO mail-qt1-f173.google.com) (209.85.160.173)
  by pb1.pair.com with SMTP; 13 Jan 2019 18:54:07 -0000
Received: by mail-qt1-f173.google.com with SMTP id e5so23966568qtr.12
        for <internals@lists.php.net>; Sun, 13 Jan 2019 07:29:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:from:date:message-id:subject:to;
        bh=fB80C3hkaz1WUWFyA4QD1i0p0pg7n4iwvrC3B8KxzuY=;
        b=grlsihcbxzfLb7k416rxEXGGOTN/o0eOEde5eyiAjUiHBx+NZ9n9b51vD8Mtlw+cGJ
         jSz9+0rKXbR5hKj+UAYMmjA0t+34m/oBeJ0a2QB3xhvQvgWONPCG39b1bTi1reWg2fBS
         ErUJfRu/RhmISoSy4f22kGLNLDXzjaOScKU1FNoxYA7nCqkZu6BSVMZW85M/1qco/wtC
         7eWE34vDQYaVDwcLg29DPKbv8raxXdwGusHBQ4LXDEivwWJzj83/wa3ziF2gx0rxzyai
         f4YQPAeffcC4DX8X6Nz8XyNM+S8zhxOWUxJVy+5aF+DHQhHjmXxpF+uo4Lt7oD4ii7+4
         8nZw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=fB80C3hkaz1WUWFyA4QD1i0p0pg7n4iwvrC3B8KxzuY=;
        b=WOGtPTu0OuQDEdJjCpbtLHpeBy9pH4wANfi2uVu2BjIuMim6KzCrObfToq742HnV03
         f9zMv+4uetg0QeR4kVUcSvlOOh51Gh34KjejKK/+Jv9MWLRey2x3f1zsKcixufVClCWp
         yzNga6c8+6rDJcB+X37d7HyvdrXW1on5kRQ/EwqGXVpW8UXKJsjm1z1/wVkOLqYKXh9t
         yN2Hr14zVGvLgVkEdwISUXnIogY66E/iO99t6dA9Pxu3zIbvCqcS34S3250apjBETIvM
         G7NaHRKYZ2HHaTT7u8/ywADJTCqF0F5KFfEmpg4T3rZIzEHl4osuggZnqTbssBHX4jqd
         likA==
X-Gm-Message-State: AJcUukf4B6qr1srI29CuuPkpXs6BWMxJFoh05vICKZeqQvA61GeEe8nK
	W5hiEphjgE2PcBIVc10JxizPOdUF2gUJmBb2QeoeO64V
X-Google-Smtp-Source: ALg8bN6C6Nr1ndg/LV9rwLbUVCqXuV70rSQA4Z1ZOHzjUlwhshrxc97Slqpaxu4aNyEyZQ4+mj2jyw/yGmkuHqkuBnU=
X-Received: by 2002:a0c:f053:: with SMTP id b19mr20983175qvl.29.1547393371066;
 Sun, 13 Jan 2019 07:29:31 -0800 (PST)
MIME-Version: 1.0
Date: Sun, 13 Jan 2019 16:29:19 +0100
Message-ID: <CACDmYycY+7gBKQzRMt2=M5bJNLy8+wYoof0kOC_a6tpNexfptg@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000035d3e5057f589888"
Subject: [PHP-DEV][RFC] mb_str_split
From: legale.legale@gmail.com (Legale Legage)

--00000000000035d3e5057f589888
Content-Type: text/plain; charset="UTF-8"

Hello, internals!
NikiC wrote very detailed review about my mb_str_split. So i rewrote the
function completely. While i was working on new implementation i've noticed
something in the mbfl library functions: mbfl_substr and mbfl_strlen.


if (encoding->flag & MBFL_ENCTYPE_SBCS) {
len = string->len;
} else if (encoding->flag & (MBFL_ENCTYPE_WCS2BE | MBFL_ENCTYPE_WCS2LE)) {
len = string->len/2;
} else if (encoding->flag & (MBFL_ENCTYPE_WCS4BE | MBFL_ENCTYPE_WCS4LE)) {
len = string->len/4;
}

There is 2 more 2-bytes width encodings: MBFL_ENCTYPE_MWC2BE (UTF16-BE),
MBFL_ENCTYPE_MWC2LE (UTF16-LE).

Is this a mistake or not?

Please check:
https://github.com/php/php-src/blob/30668755b64aa732246d952451f89d1fcfe581f0/ext/mbstring/libmbfl/mbfl/mbfilter.c#L659

--00000000000035d3e5057f589888--