Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:10369 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13734 invoked by uid 1010); 10 Jun 2004 07:55:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 13403 invoked from network); 10 Jun 2004 07:55:48 -0000 Received: from unknown (HELO is.magroup.ru) (213.33.179.242) by pb1.pair.com with SMTP; 10 Jun 2004 07:55:48 -0000 Received: from localhost.localdomain ([192.168.3.226]) by is.magroup.ru with Microsoft SMTPSVC(5.0.2195.6713); Thu, 10 Jun 2004 11:56:27 +0400 Date: Thu, 10 Jun 2004 11:56:26 +0400 To: internals@lists.php.net Message-ID: <20040610115626.7984e4b5.tony2001@phpclub.net> In-Reply-To: References: <20040609150030.18f59a2c.tony2001@phpclub.net> <20040609155610.0425464f.tony2001@phpclub.net> X-Mailer: Sylpheed version 0.9.11 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 10 Jun 2004 07:56:27.0100 (UTC) FILETIME=[6EB109C0:01C44EC0] Subject: Re: [PHP-DEV] stripslashes() improvements From: tony2001@phpclub.net (Antony Dovgal) On Thu, 10 Jun 2004 10:50:09 +0300 "Alexander Valyalkin" wrote: > On Wed, 9 Jun 2004 15:56:10 +0400, Antony Dovgal > wrote: > > > If you think it's wrong - prove it. > > There are quite detailed reasons why those bugs were considered to > > be bogus. > > > > I'm ok if you're going to improve stripslashes() efficiency and/or > > to make it just faster, this could be very useful addon. But I doubt > > it needs some kind of'fixing', 'cos it works ok ATM, as I know. > Ok, my version of stripslashes() is faster, clearer, works correctly > with old > tests and solves mentioned bugs. Are you still doubt? Try to compare > the old > (current) code to new one. Faster is ok, but you'd better read what Rasmus said. And again, trying to fix BOGUS bugs you're going wrong way. --- WBR, Antony Dovgal aka tony2001 tony2001@phpclub.net || antony@dovgal.com