Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103676
MIME-Version: 1.0
References: <CAFMT4Nodo_8dw4UkwZqT4vzE1=27xd7wczf=JxYu=R3j71xXag@mail.gmail.com>
In-Reply-To: <CAFMT4Nodo_8dw4UkwZqT4vzE1=27xd7wczf=JxYu=R3j71xXag@mail.gmail.com>
Date: Thu, 3 Jan 2019 08:28:10 -0700
Message-ID: <CAFMT4NoyOVYT7U0cbDSOLA3jtipcdtPdaLEWPHPbg3FZSoOprA@mail.gmail.com>
To: internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [RFC][Vote] Covariant Returns and Contravariant Parameters
From: levim@php.net (Levi Morrison)

On Wed, Dec 19, 2018 at 4:10 PM Levi Morrison <levim@php.net> wrote:
>
> Thank you for the feedback and discussion on the [Covariant Returns
> and Contravariant Parameters RFC][1].
>
> I have opened [voting on this RFC][2]. Given that this is a common
> time for holidays for many people around the world it will be open
> until at least January 2nd. Happy holidays!
>
>   [1]: https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters
>   [2]: https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters#voting

Currently there are 31 yes votes, and only 1 no vote. I will leave the
vote open for a few more days while I examine an issue that Dmitry
mentioned here on the list. When we have code like the following, no
errors or warnings are generated but there should be a warning:

    <?php
    class A {}
    class X {
      function m(A $z) {}
    }
    class Y extends X {
      function m(NotAnA $z) {}
    }
    ?>

I am intentionally not generating a warning at runtime for some cases.
The engine already issues a warning at compile time for some similar
cases and I didn't want to duplicate the warning at runtime.
Apparently this code is not precise enough.