Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:103654 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 2319 invoked from network); 31 Dec 2018 00:33:36 -0000 Received: from unknown (HELO blaine.gmane.org) (195.159.176.226) by pb1.pair.com with SMTP; 31 Dec 2018 00:33:36 -0000 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1gdiF0-0004oN-Cp for internals@lists.php.net; Sun, 30 Dec 2018 22:03:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: internals@lists.php.net Reply-To: Alexander Kurilo Date: Mon, 31 Dec 2018 00:05:27 +0300 Lines: 20 Message-ID: References: <19588601-decc-1110-3d1d-21207b1908c0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 In-Reply-To: Content-Language: en-US-large Subject: Re: [PHP-DEV] Broken openssl tests on Travis From: internals@lists.php.net ("Alexander Kurilo via internals") On 30/12/2018 23:29, Stanislav Malyshev wrote: > Hi! > >> There are 2 ways out: >> * This PR https://github.com/php/php-src/pull/3698 aims to solve the >> root cause: it modifies tests in order to make them generate >> certificates on the fly and always be sure that their expiration date is >> in the future (and also unties lots of tests from single certificate) > > This one looks like a bit large, probably reviewing it is going to take > time, especially given as we have holiday season now when people are > offline a lot. So I'd suggest to make a patch with a cert extended for > another 3-4 months and continue to work on this patch to fix it once and > for all. > That's reasonable. I'll create a PR with extended certs in 12 hours or so. Thanks, Alex.