Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103643
MIME-Version: 1.0
References: <CAFMT4Nodo_8dw4UkwZqT4vzE1=27xd7wczf=JxYu=R3j71xXag@mail.gmail.com>
 <DM6PR02MB593219A576A1618E7D600C9DBFBF0@DM6PR02MB5932.namprd02.prod.outlook.com>
 <DM6PR02MB5932213FE22E684434FD1557BFBF0@DM6PR02MB5932.namprd02.prod.outlook.com>
 <CAFMT4NrRQnkttJDdBXpyB=8EQC62_MnRfGAJU1hPp3nbUCW-dA@mail.gmail.com>
 <f91e88da-a873-dd0a-28e2-4c58cd685064@zend.com> <DM6PR02MB5932BD07A788466EA2880114BFBB0@DM6PR02MB5932.namprd02.prod.outlook.com>
In-Reply-To: <DM6PR02MB5932BD07A788466EA2880114BFBB0@DM6PR02MB5932.namprd02.prod.outlook.com>
Date: Thu, 27 Dec 2018 10:48:44 -0700
Message-ID: <CAFMT4NqxV4zsepa-Zh7vYCj6yjr9Xr0cb__eqhF6J2TnApGvpA@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters
From: levim@php.net (Levi Morrison)

> 2. But this test misses warning
>
>
> <?php
> $q = 1;
> if ($q) {
>         class C {}
>         class D {}
> }
>
> class A {
>         function bar(C $c) {}
> }
> class B extends A {
>         function bar(D $D) {
>                 echo "ok\n";
>         }
> }
> ?>

The code detects this as an error but intentionally does not report it
because in other cases a warning is already issued and I did not want
to re-issue the warning again. I'll dig into this more to see why it
is not issued the first time in this case.

However, this should *remain* a warning to be consistent with existing
code. When a class extends another non-abstract class and there isn't
an interface involved then it's only a warning. We should fix this in
PHP 8.0 for all cases.