Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103631
To: Dmitry Stogov <dmitry@zend.com>, Levi Morrison <levim@php.net>
Cc: internals <internals@lists.php.net>
References: <CAFMT4Nodo_8dw4UkwZqT4vzE1=27xd7wczf=JxYu=R3j71xXag@mail.gmail.com>
 <DM6PR02MB593219A576A1618E7D600C9DBFBF0@DM6PR02MB5932.namprd02.prod.outlook.com>
 <DM6PR02MB5932213FE22E684434FD1557BFBF0@DM6PR02MB5932.namprd02.prod.outlook.com>
 <CAFMT4NrRQnkttJDdBXpyB=8EQC62_MnRfGAJU1hPp3nbUCW-dA@mail.gmail.com>
 <f91e88da-a873-dd0a-28e2-4c58cd685064@zend.com>
 <DM6PR02MB5932BD07A788466EA2880114BFBB0@DM6PR02MB5932.namprd02.prod.outlook.com>
Message-ID: <456be1f6-df57-9e1b-8298-f81564adf89c@gmx.de>
Date: Mon, 24 Dec 2018 14:22:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <DM6PR02MB5932BD07A788466EA2880114BFBB0@DM6PR02MB5932.namprd02.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC][Vote] Covariant Returns and
 ContravariantParameters
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 24.12.2018 at 13:20, Dmitry Stogov wrote:

> - The patch is incompatible with opcache (crashes on Wordpress, Drupal, and probably any real-life app).
> 
> - the incompatibility with opcache, doesn't allow to check the performance implication of the patch
> 
> - the patch has merge conflicts and travis tests doesn't run.
> 
> 
> Personally, I'm not against the proposal, but I'm definitely against this implementation.
> 
> Probably, it's better to cancel the voting and restart when the implementation is ready.
> 
> 
> It's pity to see, that nobody tries the implementation but blindly vote...

Well, one may argue that the voting is about the concept, but not about
a (preliminary) implementation.  The main concern, in my opinion, is
rather whether it is possible to implement the proposal without (much)
drawbacks (such as general performance regression).  A working patch
would be helpful to prevent cases where we accept a proposal, but later
face difficulties implementing it and/or can't agree on some of the
details[1][2].  We may consider to augment the RFC process to clearly
require a working implementation before starting the vote.

[1] <https://wiki.php.net/rfc/null_coalesce_equal_operator>
[2] <https://wiki.php.net/rfc/notice-for-non-valid-array-container>

-- 
Christoph M. Becker