Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103616
To: Levi Morrison <levim@php.net>, internals <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant
 Parameters
Thread-Index: AQHUl/AqXVQDKTyJX0uvYhkVZIp9sqWHwGIygABrD7I=
Date: Thu, 20 Dec 2018 22:35:10 +0000
Message-ID:
 <DM6PR02MB5932213FE22E684434FD1557BFBF0@DM6PR02MB5932.namprd02.prod.outlook.com>
References:
 <CAFMT4Nodo_8dw4UkwZqT4vzE1=27xd7wczf=JxYu=R3j71xXag@mail.gmail.com>,<DM6PR02MB593219A576A1618E7D600C9DBFBF0@DM6PR02MB5932.namprd02.prod.outlook.com>
In-Reply-To:
 <DM6PR02MB593219A576A1618E7D600C9DBFBF0@DM6PR02MB5932.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_DM6PR02MB5932213FE22E684434FD1557BFBF0DM6PR02MB5932namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ff8bf8a0-7b5b-435c-921f-08d666cb66a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2018 22:35:10.3872
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR02MB1114
Subject: Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant
 Parameters
From: dmitry@zend.com (Dmitry Stogov)

--_000_DM6PR02MB5932213FE22E684434FD1557BFBF0DM6PR02MB5932namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Levi,


It looks like the patch broke something related to opcache.

It crashes at least on Wordpress and Drupal.

The backtrace https://gist.github.com/dstogov/a2305381a5c9982cceca9e4e252d2=
6c7 shows use-after-free in opcache (works fine with master).

Inability to work with opcache, doesn't allow to check the performance impa=
ct.


It also broke few tests. Some crash. Some produce different warning/errors.


$ make test TESTS=3D"Zend tests"

...

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
FAILED TEST SUMMARY
---------------------------------------------------------------------
ZE2 ArrayAccess and ArrayAccessReferenceProxy with references to main array=
 [tests/classes/array_access_011.phpt]
Bug #21478 (Zend/zend_alloc.c :: shutdown_memory_manager produces segfault)=
 [Zend/tests/bug21478.phpt]
Generator methods can yield by reference [Zend/tests/generators/generator_m=
ethod_by_ref.phpt]
Testing to implement Serializable interface by traits [Zend/tests/traits/in=
terface_003.phpt]
Handling of public fields with traits needs to have same semantics as with =
normal inheritance, however, we do add strict warnings since it is easier t=
o run into something unexpeted with changing traits. [Zend/tests/traits/pro=
perty009.phpt]
iterable type#004 - Parameter covariance [Zend/tests/type_declarations/iter=
able_004.phpt]
iterable type#005 - Return type covariance [Zend/tests/type_declarations/it=
erable_005.phpt]
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D


I'll try to play with patch and make a full code review on next week.


It would be great, if you fix opcache compatibility.

If it can't be done in reasonable time, it's probably better to cancel voti=
ng and restart when ready.


Thanks. Dmitry.


________________________________
From: Dmitry Stogov <dmitry@zend.com>
Sent: Thursday, December 20, 2018 6:26:10 PM
To: Levi Morrison; internals
Subject: Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Para=
meters

Hi Levi,


Please, create a Pull Request, to keep inline comments on github.


Thanks. Dmitry.

________________________________
From: Levi Morrison <levim@php.net>
Sent: Thursday, December 20, 2018 2:10:57 AM
To: internals
Subject: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Paramete=
rs

Thank you for the feedback and discussion on the [Covariant Returns
and Contravariant Parameters RFC][1].

I have opened [voting on this RFC][2]. Given that this is a common
time for holidays for many people around the world it will be open
until at least January 2nd. Happy holidays!

  [1]: https://wiki.php.net/rfc/covariant-returns-and-contravariant-paramet=
ers
  [2]: https://wiki.php.net/rfc/covariant-returns-and-contravariant-paramet=
ers#voting

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php


--_000_DM6PR02MB5932213FE22E684434FD1557BFBF0DM6PR02MB5932namp_--