Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103533
To: Dan Ackroyd <Danack@basereality.com>,
 =?UTF-8?Q?Micha=c5=82_Brzuchalski?= <michal@brzuchalski.com>
Cc: PHP internals <internals@lists.php.net>
References: <CAF+90c_wZvdgVbmdHH+7J=CLx-rivDRr4vB3=HXK3K2HSNAqMg@mail.gmail.com>
 <CAJVEVOaZWJPNS9YMU=xp2oKqXe=R3ASeA9jxz0kmS-QeLR-OJA@mail.gmail.com>
 <CABdc3Wp62iVR07apx2jRXLF2iQHU=WRNQaVvaiKwBODAFqUwJg@mail.gmail.com>
 <CA+kxMuQFogPb11T=G=2yr43_oORRgyeReSKJs2V7a8TU9w5DgQ@mail.gmail.com>
Message-ID: <5116704f-a944-f7e6-dbef-8e5a79c40b88@gmx.de>
Date: Thu, 29 Nov 2018 12:49:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <CA+kxMuQFogPb11T=G=2yr43_oORRgyeReSKJs2V7a8TU9w5DgQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Subject: Re: Error warning change idea
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 29.11.2018 at 12:24, Dan Ackroyd wrote:

> On Thu, 29 Nov 2018 at 09:59, Michał Brzuchalski <michal@brzuchalski.com> wrote:
>>
>> I don't really know if it fits here but some weeks ago I was thinking about
>> annotations with "@" prefix
>> ....
>>
>> Which might work as supress all errors except fatal errors.
>>
>> Does that sound like a solution at all?
>> The developer then has full controll on what errors are suppressed or not..
> 
> I was thinking along similar lines a while ago:
> https://gist.github.com/Danack/5ae0b1b1ce30a0d785dd
> 
> The reason I never formally suggested it as an RFC is that I think
> it's doubling down on the wrong solution.
> 
> The vast majority of places where errors/warning are used currently,
> could either be just removed or have the result of the function be
> changed to be a tuple of the current result, and an error
> flag/message.
> 
> [$result, $error] = foo($bar);
> if ($error !== null) {
>   // something went wrong.
> }
> // $result is usable

If a function issues a warning and returns some value indicating
failure, we should consider to let the function throw an exception
instead.  Typical cases would be getimagesize(), fopen() and
password_hash(), for instance.

-- 
Christoph M. Becker