Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103419
MIME-Version: 1.0
References: <CALYT1YpSw7NyGugVgmuppx9c46nBzXDz8Ovpfadyz944ZqV-4Q@mail.gmail.com>
 <CAF+90c8=yfH0PPEGJUizgTiQVcBZ5u7SALx9vvaTutVAHuf2Cg@mail.gmail.com>
In-Reply-To: <CAF+90c8=yfH0PPEGJUizgTiQVcBZ5u7SALx9vvaTutVAHuf2Cg@mail.gmail.com>
Date: Sun, 4 Nov 2018 17:01:17 +0000
Message-ID: <CAEKnhAFDsEVP8KeoKDSwOapdSctqDsDMfbyW0nzq2vuJgEQYtA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: me@sammyk.me, PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000027ad1b0579d9b89c"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Improve openssl_random_pseudo_bytes()
From: bukka@php.net (Jakub Zelenka)

--00000000000027ad1b0579d9b89c
Content-Type: text/plain; charset="UTF-8"

On Sat, Nov 3, 2018 at 10:27 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Fri, Nov 2, 2018 at 8:30 PM Sammy Kaye Powers <me@sammyk.me> wrote:
>
> > Hey internals!
> >
> > Given there has been at least two weeks of discussion around the RFC,
> > "Improve openssl_random_pseudo_bytes()" and there doesn't seem to be
> > any outstanding issues, I have moved the RFC into voting phase.
> >
> > The voting period lasts two weeks; from now until 2018-11-16.
> >
> > The RFC can be found here:
> > https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes
> >
> > Happy voting! :)
>
>
> I've voted against the deprecation of the $crypto_strong param. IMHO we
> should just document that it is guaranteed to always be true if the call
> succeeds and checking it is not necessary. But we should not penalize
> existing code that is checking the flag -- it may no longer necessary
> nowadays, but previously that was the correct use of the function.
>
>
I think this is a good point so voted against it too.

--00000000000027ad1b0579d9b89c--