Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103418
Return-Path: <sammyk@sammykmedia.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 6470 invoked from network); 3 Nov 2018 21:30:54 -0000
Received: from unknown (HELO mail-lj1-f175.google.com) (209.85.208.175)
  by pb1.pair.com with SMTP; 3 Nov 2018 21:30:54 -0000
Received: by mail-lj1-f175.google.com with SMTP id g26-v6so4443823lja.10
        for <internals@lists.php.net>; Sat, 03 Nov 2018 10:48:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=sammyk-me.20150623.gappssmtp.com; s=20150623;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=OIuS09SLvMcwkGpoYqJDCvzMUj9ryPqIjJcJVL4RnZs=;
        b=Dy+URSmZ6CFjt1ctmWiCUpFuFEH3uGy5EKOP/mt24poMg5JoibVJq8LBDk7EsUiqrw
         q02SyQKCTKz8rWLhwuDhFOfYnQhHzXzCEYc6GNZO5Jy+yk8hNdK91E1Nxql8Ph+uHXEc
         Ce3atcw//TTLyOm6bpBdSu+L/t/JOoBoMYzF38y3mMCdvXWAqrVGYEG7fuhtrjT0Mm1C
         z+bReypRn+MzylnIc4gECrSyhXGsaOKmpbSsbTGForGUtL4ANyHGkphKsa07OaGvCYAO
         SPRU6xP36LriWAwohyufIOO023WJ19BUBtBuCfd/oz3Jvg7p4q5zO+K6ArTbPyvZJo48
         XvRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=OIuS09SLvMcwkGpoYqJDCvzMUj9ryPqIjJcJVL4RnZs=;
        b=nVwOv6841RUEKJNnQNvNaMDUAvJuNsyYtSHJY0hKX1truE9YPGamFJwejTIVnbUTox
         vjXidjyD9Ishz+LXkBF3si9DPjex7FkRtVeQKpQBGehzJ+bxTCwK6jVANcw04zm/5U3s
         wJbXeOZUt62EFBCM9fMSs5wqMwrt9wDRIgEYArgyumN49gVZo+R83PsIOky3SjAjfZrw
         KJqB7ff1Z+YxNPFc6sR3TL1dN5wnyaYAW9yW7FGpdci2W2UY1mn/RYVW5gXR4PK9ZuNX
         OqXAOg3O3zRVrKXJiz4Zv8ekjrHEfuC+tx03bqTVckNJNCJcxl6G3GRRpowYunyacxfb
         F0BQ==
X-Gm-Message-State: AGRZ1gJ9bv0T6mkVJ3cU/T0DvGBU1EcWlrtYUHtaOQ/t1ZUVgifdOK9l
	TnBx4WuhH9NTIVyGaJCfvuosVNsDpNonHCIf0EUJTA==
X-Google-Smtp-Source: AJdET5fJvDfVLMF85m8Gyz0dWngtKr9jFjDfNHNWa5Pqu+LIZeYfGVyhs40ounRLe4KxTdyO1N3oJKrWpP0eWsdAgL0=
X-Received: by 2002:a2e:9059:: with SMTP id n25-v6mr7445307ljg.155.1541267314281;
 Sat, 03 Nov 2018 10:48:34 -0700 (PDT)
MIME-Version: 1.0
References: <CALYT1YpSw7NyGugVgmuppx9c46nBzXDz8Ovpfadyz944ZqV-4Q@mail.gmail.com>
 <CAF+90c8=yfH0PPEGJUizgTiQVcBZ5u7SALx9vvaTutVAHuf2Cg@mail.gmail.com>
In-Reply-To: <CAF+90c8=yfH0PPEGJUizgTiQVcBZ5u7SALx9vvaTutVAHuf2Cg@mail.gmail.com>
Date: Sat, 3 Nov 2018 12:48:22 -0500
Message-ID: <CALYT1YoH4vq9nmWN=Vq4t37VZRY5zu6p_TFNQkXU-gAxP7bi9Q@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [VOTE] Improve openssl_random_pseudo_bytes()
From: me@sammyk.me (Sammy Kaye Powers)

@Niklas: Ooops! Thanks for pointing that out. Done! :)
https://github.com/php/php-src/pull/3649

@Nikita
> IMHO we should just document that it is guaranteed to always be true if t=
he call succeeds and checking it is not necessary. But we should not penali=
ze existing code that is checking the flag -- it may no longer necessary no=
wadays, but previously that was the correct use of the function.

That's fair. I'm just thinking of devs that will encounter the second
param outside of the docs (i.e. via their IDE hints). And since
ext/openssl seems to be here for the long haul, the goal would be to
have a non-confusing API going forward. But I can totally see your
point as well which is the main reason I went for two separate votes.
:)

Thanks,
Sammy Kaye Powers
sammyk.me