Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:103417 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 34643 invoked from network); 3 Nov 2018 14:09:35 -0000 Received: from unknown (HELO mail-it1-f182.google.com) (209.85.166.182) by pb1.pair.com with SMTP; 3 Nov 2018 14:09:35 -0000 Received: by mail-it1-f182.google.com with SMTP id w7-v6so6477681itd.1 for ; Sat, 03 Nov 2018 03:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jFmM+K8jj1EFalHeEZyq9wGAgP/uKC9G0RVB8dSNgfk=; b=trX5iiuCHxge/tIsL8PvH6Q4rlTODuovLEXBY6wr3Kah7Q4lfswqg9rA2w47XBEo8l YWn1+znu6Xo+0YfC5zrF5bPY1yzzj9PefYFguTfIAgf8Ho/aXexH+L19SqzFCqSYlKta Y1ZmZhDZ4FqsuN0ZIbmU4MLiS6b0nB2OJrYgNFEaaa1ObSUc0rjzkq2StTufgfWZDGJC PotrjfUl9ImmGfEBouAZ+dck6EOvGsy4EthmiNMMZmruxb9rWXxmYKj7p/VAjOGmf/qK 8B7A45ADx3KxEGKOxt7U9z2E654bE5JvEsMpbIDB4gCV2bjgKVBCLy0NOAFchx6sPApa kjNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jFmM+K8jj1EFalHeEZyq9wGAgP/uKC9G0RVB8dSNgfk=; b=UzCl0e2cj5NlMLPMXZi1Z2ZWso4BD2gmhSbjwwN/uc5g2yzGR93RnDbBBQw/P9SUqB 7qATgNLrr5m+zqkp4FcTjUdvMaEhkcdsgNjbz+egjZPZn7B0ppdFlJoOy8ItT2+cZA80 PT3+GKu8TwLy/zd3d+9giHY+zL+HqdxO9gij/bqZhlzHGFZq54OkIUhzHRE1P1D+NvU9 wYBeNkqotSJUC3Tb7UiOKQhAJRH1/k6y2aX6YQZLN9A+DqlZPu5sM49okqh2OALDYiSF jDQRdcsnv219SboqtWpIvHUGwjTRwP6FrCOHhnx9sYozFFs028wPdVHi26bKfx1j1cNl S/gg== X-Gm-Message-State: AGRZ1gKYcSmzcWID82oI7nTxCFYgbMJfhEXAelhFGdGl8QPHwTzFMyA8 vklAoglsNEx6fFyx9X+gcJQigFuFTHkVv9XkBKLoV0fJ X-Google-Smtp-Source: AJdET5eKwop+zSmCS0/5DslFKBsXO/72TCCT8si99sbDWwZDxyE9ZLaT5YKJfxJp6UJhvH9rWKoZo2aE891BeTJJEIM= X-Received: by 2002:a02:5f96:: with SMTP id x22-v6mr13626566jad.43.1541240831587; Sat, 03 Nov 2018 03:27:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Sat, 3 Nov 2018 11:26:54 +0100 Message-ID: To: Sammy Kaye Powers Cc: PHP internals Content-Type: multipart/alternative; boundary="00000000000047bc120579c01899" Subject: Re: [PHP-DEV] [RFC] [VOTE] Improve openssl_random_pseudo_bytes() From: nikita.ppv@gmail.com (Nikita Popov) --00000000000047bc120579c01899 Content-Type: text/plain; charset="UTF-8" On Fri, Nov 2, 2018 at 8:30 PM Sammy Kaye Powers wrote: > Hey internals! > > Given there has been at least two weeks of discussion around the RFC, > "Improve openssl_random_pseudo_bytes()" and there doesn't seem to be > any outstanding issues, I have moved the RFC into voting phase. > > The voting period lasts two weeks; from now until 2018-11-16. > > The RFC can be found here: > https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes > > Happy voting! :) I've voted against the deprecation of the $crypto_strong param. IMHO we should just document that it is guaranteed to always be true if the call succeeds and checking it is not necessary. But we should not penalize existing code that is checking the flag -- it may no longer necessary nowadays, but previously that was the correct use of the function. Nikita --00000000000047bc120579c01899--