Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103349
Return-Path: <sammyk@sammykmedia.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 71876 invoked from network); 20 Oct 2018 16:47:18 -0000
Received: from unknown (HELO mail-lj1-f174.google.com) (209.85.208.174)
  by pb1.pair.com with SMTP; 20 Oct 2018 16:47:18 -0000
Received: by mail-lj1-f174.google.com with SMTP id x3-v6so33106556lji.13
        for <internals@lists.php.net>; Sat, 20 Oct 2018 06:01:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=sammyk-me.20150623.gappssmtp.com; s=20150623;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=p5IxY2de8UMNA/8f1aZA/GfHeVGwX4sAiRTQmiU/cm4=;
        b=RgqLmit8X1hvTFyopEBaXDdSWBR9HTgGjxOwAIimbZHx3RxSQHFajPfnUX32GK2RSO
         YE+M6RuDkrDWu1biMHifhYV5RKksfEwITPMe4nK2Hp4ttwUySDEMtnr/VVKcMEiELUUQ
         K/844PhZVQfffyW7PJK+S5jbqkCjkm3h+kyC5mOn5nE9rplxfMpBT3fTuKww+57eOKt7
         5cum9lmGTS999oyPK4dWDKvdZTYuDSqAmRWhdJBqpZxclwfnTmXt8mIzgnD9/2JSGCAr
         dXjE9vH1i6FU4i8gkFqorqDu5cZfzLZw3ffFdfaEJBx5KiVWqJx80ZXbjekWgadk/IKv
         PcTg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=p5IxY2de8UMNA/8f1aZA/GfHeVGwX4sAiRTQmiU/cm4=;
        b=FZyVl2OAaf9/2StSDRijzjtJuAj0ZCMPUjDs0kAnVdUcP/mC+HK8QDKi7KUsUOmnAv
         aL0O92LiLilTHuxPLQUlhfXWI6uH8Zu1OUfP6s5uXcarfX2eK74Ai6q8s+c0P4ldwg8W
         t3Z3bW2xCSe5Jra3UujOahqxFwVJKLBau4/BJQZiLYPMTCCct7Z5VvtO9QioVE4h8oxw
         OK8DN3lJl8J2kwQP2WrmJLJ/mGte0CvRNK4nw199z2x0YQTkzoAkEYmrpxLEUnYBvRZi
         xLc4b5rXh9ju0fpgJm+digWJlzGlUATMR2FzdYJq39zpDyMOh5hCd/LQjJccyf/aklvV
         KaCA==
X-Gm-Message-State: AGRZ1gKTRM7/5Xr6b0Q0ATAaiC9nfL+8K4dHUEcLdXLUQ8I7wZ8nShwR
	eYmmbwLbB43nOC8NH+DO0dhxdKSIp5MIqiRhbxE1Zg==
X-Google-Smtp-Source: AJdET5dRPLVreYgyTAkEUwlRBBVLf9BNq16FcbAQnUGMx3ILHLXxUoPIbbPjQaZO/+uwsNFfXzKJjJ3GjcTjWobRdB4=
X-Received: by 2002:a2e:8743:: with SMTP id q3-v6mr4292735ljj.80.1540040485249;
 Sat, 20 Oct 2018 06:01:25 -0700 (PDT)
MIME-Version: 1.0
References: <CALYT1Yohs0fL_nfHzsSuhpT=4-69e-N3oAJdeW0NO64E9ma6GQ@mail.gmail.com>
 <CAESVnVobU3VvK3_5YU8k4AvxAJG3B6uLshGf0hy3UaB4imEHhA@mail.gmail.com> <CAESVnVrD6PtE25S4nvkaqLzKfqERp6N=PgKtBMC8mq4vGRbq7g@mail.gmail.com>
In-Reply-To: <CAESVnVrD6PtE25S4nvkaqLzKfqERp6N=PgKtBMC8mq4vGRbq7g@mail.gmail.com>
Date: Sat, 20 Oct 2018 09:01:13 -0400
Message-ID: <CALYT1Yr0OZsj5uzvyea2K=_4H0tFE+VgFm+OMKD7nT9r9_zeYw@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Improve openssl_random_pseudo_bytes()
From: me@sammyk.me (Sammy Kaye Powers)

On Fri, Oct 19, 2018 at 10:21 PM Sara Golemon <pollita@php.net> wrote:
>
> On Fri, Oct 19, 2018 at 9:20 PM Sara Golemon <pollita@php.net> wrote:
> > On Fri, Oct 19, 2018 at 3:47 PM Sammy Kaye Powers <me@sammyk.me> wrote:
> > > I'd like to start a discussion on the "Improve
> > > openssl_random_pseudo_bytes()" RFC:
> > > https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes
> > >
> > lgtm; though a small nit: s/RETURN_BOOL(pzv, 1)/RETURN_TRUE(pzv)/g
> > Slightly more readable that way.
> >
> Or rather:   ZVAL_BOOL(pzv, 1)  => ZVAL_TRUE(pzv)

Good call - done! :)