Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103347
Return-Path: <php@golemon.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 71079 invoked from network); 20 Oct 2018 06:07:35 -0000
Received: from unknown (HELO mail-qk1-f193.google.com) (209.85.222.193)
  by pb1.pair.com with SMTP; 20 Oct 2018 06:07:35 -0000
Received: by mail-qk1-f193.google.com with SMTP id m8-v6so22193120qka.12
        for <internals@lists.php.net>; Fri, 19 Oct 2018 19:21:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=HodvPGMne33wx6aczlxmLXEvjEucCVaBHCcg3a3Xi40=;
        b=hEgCs5c9YlYCC2YiD4cTCm+BS0whpCIPC+kIbDNNCKtaMA7YC4Dlep6aNHYZXPVzJS
         NsMljnj4skbxNhaebpW+6cCSZUOyfILuVYZ2rIpQL0ndOpAnQLcFsVxz3psnOXWzGU/0
         wks5HHb/faJ1eoZ6MkqApEhhQbND9SaJDC+ib3MEh/d6RpNIZ6MXumVF+olRtduugVkV
         VUo/NFib0j1Alx8z6HRS39hfXMDe70F2K2hducNPsi18oD3Eo3wJZ+O0WyGlBpzgK2Jp
         OzBS4w4zeza5mjegkniE/Eo5Zrc5Ml5+VQrTCH723LPUFmRYGLg3JCSi8HkiZxbAXKNP
         otqQ==
X-Gm-Message-State: ABuFfogdljBuLN8zbncemmGqJZgPqdlJL72dIlW5A6XrwOZykWoqnd24
	61jdUOELi8pu26GAmMHh364t7ihy55HV+yr2Zp02NtAnvbY=
X-Google-Smtp-Source: ACcGV60yhYgckAXWhOZNOWpWYEZth94ekpMtokzWe34tges7Ud5/jvfZR+03mMUrLFMnkuriZLojTrxQOqzePDMzco4=
X-Received: by 2002:a37:a6d8:: with SMTP id p207-v6mr35855645qke.226.1540002096660;
 Fri, 19 Oct 2018 19:21:36 -0700 (PDT)
MIME-Version: 1.0
References: <CALYT1Yohs0fL_nfHzsSuhpT=4-69e-N3oAJdeW0NO64E9ma6GQ@mail.gmail.com>
 <CAESVnVobU3VvK3_5YU8k4AvxAJG3B6uLshGf0hy3UaB4imEHhA@mail.gmail.com>
In-Reply-To: <CAESVnVobU3VvK3_5YU8k4AvxAJG3B6uLshGf0hy3UaB4imEHhA@mail.gmail.com>
Date: Fri, 19 Oct 2018 21:21:25 -0500
Message-ID: <CAESVnVrD6PtE25S4nvkaqLzKfqERp6N=PgKtBMC8mq4vGRbq7g@mail.gmail.com>
To: Sammy Kaye Powers <me@sammyk.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Improve openssl_random_pseudo_bytes()
From: pollita@php.net (Sara Golemon)

On Fri, Oct 19, 2018 at 9:20 PM Sara Golemon <pollita@php.net> wrote:
> On Fri, Oct 19, 2018 at 3:47 PM Sammy Kaye Powers <me@sammyk.me> wrote:
> > I'd like to start a discussion on the "Improve
> > openssl_random_pseudo_bytes()" RFC:
> > https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes
> >
> lgtm; though a small nit: s/RETURN_BOOL(pzv, 1)/RETURN_TRUE(pzv)/g
> Slightly more readable that way.
>
Or rather:   ZVAL_BOOL(pzv, 1)  => ZVAL_TRUE(pzv)