Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103346
Return-Path: <php@golemon.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 69713 invoked from network); 20 Oct 2018 06:06:49 -0000
Received: from unknown (HELO mail-qk1-f171.google.com) (209.85.222.171)
  by pb1.pair.com with SMTP; 20 Oct 2018 06:06:49 -0000
Received: by mail-qk1-f171.google.com with SMTP id q5-v6so22209850qki.6
        for <internals@lists.php.net>; Fri, 19 Oct 2018 19:20:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=TrsXc6sfw9JsTfV5T6EkafBrwzA/gt8hveoW3PTFxCc=;
        b=pqyKIsstAsIwIrqdNyOXkuXDG82CRzwCMTy3J5csH99gKc0QBc/kArf0TWkNlPTJXH
         vzwa/du9QSbSuWINVcd4TxxpaDOiKYPiOPWZs5t+sgKYi+q5bCIAG11f5OTauEaQXbtb
         GlZYmd/DZMBJ6LmRc1ggxE4cMc+yLb8HL3aAkF1oAmMKEOpCSqDGmys24gSVLSgvmf+w
         cQ4FOGXFwqVW6dAp98LBC+IFAqwGX6m6m+TWj75DVXniCoAA15vsla7/Ysx0u8jri8A+
         TnMFgMKWoTq/HLTiANK+on3bSdxzp3jVvGV4gDigm7ipNH8IQ8wJrZqkwtDAROkZZR+v
         eKLw==
X-Gm-Message-State: ABuFfoilVH8vQwNS6smst8hqeu4U3LROa/Db+xeNb8JCXFRRPqdtfsie
	HBkxpPVuRshgXXD4mTgtuPUk8JwB0T0Gs8g7vxhPkOgh0X8=
X-Google-Smtp-Source: ACcGV628mMbKuV7wPu2qmZNj4TSCYKuh1W/3tue3C/Rzn02JRaRkCwF0Z4yBzScf9A3pMC533ZQPuygXUBX2YQQJ1Rs=
X-Received: by 2002:a37:67c7:: with SMTP id b190-v6mr34932025qkc.116.1540002050346;
 Fri, 19 Oct 2018 19:20:50 -0700 (PDT)
MIME-Version: 1.0
References: <CALYT1Yohs0fL_nfHzsSuhpT=4-69e-N3oAJdeW0NO64E9ma6GQ@mail.gmail.com>
In-Reply-To: <CALYT1Yohs0fL_nfHzsSuhpT=4-69e-N3oAJdeW0NO64E9ma6GQ@mail.gmail.com>
Date: Fri, 19 Oct 2018 21:20:39 -0500
Message-ID: <CAESVnVobU3VvK3_5YU8k4AvxAJG3B6uLshGf0hy3UaB4imEHhA@mail.gmail.com>
To: Sammy Kaye Powers <me@sammyk.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Improve openssl_random_pseudo_bytes()
From: pollita@php.net (Sara Golemon)

On Fri, Oct 19, 2018 at 3:47 PM Sammy Kaye Powers <me@sammyk.me> wrote:
> I'd like to start a discussion on the "Improve
> openssl_random_pseudo_bytes()" RFC:
> https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes
>
lgtm; though a small nit: s/RETURN_BOOL(pzv, 1)/RETURN_TRUE(pzv)/g
Slightly more readable that way.