Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:103304 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 97214 invoked from network); 3 Oct 2018 15:42:20 -0000 Received: from unknown (HELO mailsrv1.hostingfactory.nl) (185.78.96.68) by pb1.pair.com with SMTP; 3 Oct 2018 15:42:20 -0000 Received: from localhost (localhost [127.0.0.1]) by mailsrv1.hostingfactory.nl (Postfix) with ESMTP id 5806A10420C0; Wed, 3 Oct 2018 13:52:06 +0200 (CEST) Received: from mailsrv1.hostingfactory.nl ([127.0.0.1]) by localhost (mailsrv1.hostingfactory.nl [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Gf9sedy2ypd4; Wed, 3 Oct 2018 13:52:05 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailsrv1.hostingfactory.nl (Postfix) with ESMTP id 46F7B1043C41; Wed, 3 Oct 2018 13:52:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at mailsrv1.hostingfactory.nl Received: from mailsrv1.hostingfactory.nl ([127.0.0.1]) by localhost (mailsrv1.hostingfactory.nl [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oHeJKLcC4skA; Wed, 3 Oct 2018 13:52:05 +0200 (CEST) Received: from mailsrv1.hostingfactory.nl (mailsrv1.hostingfactory.nl [185.78.96.68]) by mailsrv1.hostingfactory.nl (Postfix) with ESMTP id 30C7F10420C0; Wed, 3 Oct 2018 13:52:05 +0200 (CEST) Date: Wed, 3 Oct 2018 13:52:05 +0200 (CEST) To: Rasmus Schultz Cc: rowan collins , internals Message-ID: <1088611458.947062.1538567525094.JavaMail.zimbra@pieterhordijk.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [185.78.96.68] X-Mailer: Zimbra 8.8.8_GA_2009 (ZimbraWebClient - FF62 (Win)/8.8.8_GA_2009) Thread-Topic: deprecation of set_error_level() callback $errcontext argument Thread-Index: W44+J00ejJy4SUdAT2JH7qCIIryrog== Subject: Re: [PHP-DEV] deprecation of set_error_level() callback $errcontext argument From: info@pieterhordijk.com (Pieter Hordijk) > On Tue, Oct 2, 2018 at 11:37 PM Rowan Collins w= rote: >=20 >> While I can understand the desire to have debugging feature built into >> the language "out of the box", it may be best left to extensions which >> can capture the information to a log or wherever without providing the >> full flexibility of the language to interact with it. >=20 > I think, since the language *did* provide this "out of the box", it's sor= t of > odd to deprecate a feature that is being used by a popular product - the > Sentry PHP package has 8 million downloads, and PHP developers rely > on this in production to help them fix bugs. Seems pretty important? >=20 > And an extension isn't really an acceptable alternative to someone who > was offering a product that "just worked". >=20 > For example, rather than removing this feature, might it be possible to > deeply clone the variables and provide backwards compatibility in that > manner? I doubt that anyone is counting on introducing side-effects via > an error-handler, but surely it's not uncommon for error-aggregators and > loggers to rely on this information being available? >=20 According to the sentry people here https://github.com/getsentry/sentry-php= /issues/662#issuecomment-426550180 they don't actually use that anymore: > I've done a little bit of digging here and there, and luckily this seems = a non-issue for us! =F0=9F=8E=89 > In the 2.0 branch that argument is not used: