Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103303
MIME-Version: 1.0
References: <CADqTB_j_FpODmfz38E3mXe7dLtH=JuyjOWZ=YZsCOsEEXYndKQ@mail.gmail.com>
 <c6408299-7279-2a29-7c30-d6e8ff520c3b@gmail.com>
In-Reply-To: <c6408299-7279-2a29-7c30-d6e8ff520c3b@gmail.com>
Date: Wed, 3 Oct 2018 08:56:52 +0200
Message-ID: <CADqTB_jA4B4COKjA_QK7RhiR_tDQ6BwqH-x7vOHfkhwp9SrVtA@mail.gmail.com>
To: rowan.collins@gmail.com
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] deprecation of set_error_level() callback $errcontext argument
From: rasmus@mindplay.dk (Rasmus Schultz)

On Tue, Oct 2, 2018 at 11:37 PM Rowan Collins <rowan.collins@gmail.com> wrote:

> While I can understand the desire to have debugging feature built into
> the language "out of the box", it may be best left to extensions which
> can capture the information to a log or wherever without providing the
> full flexibility of the language to interact with it.

I think, since the language *did* provide this "out of the box", it's sort of
odd to deprecate a feature that is being used by a popular product - the
Sentry PHP package has 8 million downloads, and PHP developers rely
on this in production to help them fix bugs. Seems pretty important?

And an extension isn't really an acceptable alternative to someone who
was offering a product that "just worked".

For example, rather than removing this feature, might it be possible to
deeply clone the variables and provide backwards compatibility in that
manner? I doubt that anyone is counting on introducing side-effects via
an error-handler, but surely it's not uncommon for error-aggregators and
loggers to rely on this information being available?