Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103259
MIME-Version: 1.0
References: <OFC3B3B597.83B37DA6-ON43258312.003C9894-43258312.003E5976@alfabank.ru>
 <79483e23-7a28-aa05-5b74-bcfd52f57706@gmail.com>
In-Reply-To: <79483e23-7a28-aa05-5b74-bcfd52f57706@gmail.com>
Date: Tue, 25 Sep 2018 09:48:35 -0500
Message-ID: <CAESVnVodTGpvjvUBrNAdN4O7FGrWP3vJ6Payk18vjEvWuUVMaA@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: AGromov@alfabank.ru, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Pre proposal for "Class extension functions"
From: pollita@php.net (Sara Golemon)

On Tue, Sep 25, 2018 at 1:50 AM Stanislav Malyshev <smalyshev@gmail.com> wrote:
> > I want to do RFS proposal for new language concept - Class extension
> > functions.
> >
> > Syntax will looks like:
> >
> > function DateTime->localTime() {
> >     return $this->format('H:i');
> > }
>
> I feel this is inviting trouble. If you need additional functionality,
> why not extend the class? Or write a function that accepts DateTime as
> an argument? This encourages a style of programming where you never know
> which object does what. Even in JS, as far as I know, it's not exactly
> the recommended style. But in PHP I don't think we should be doing this.
>
I've been back-burnering this for a few days and I'm with Stas.  I
don't like this proposal because it adds complexity with relatively
little benefit.

If I wanted to add utility functions, I could create a proxy class
which encapsulates the target and has a getter for passing into
typehinted interfaces.  You get all the functionality in any existing
version of PHP without the added parser/engine complexity.

Even static properties (which sadly lack get/set accessors) could be
proxied using references so long as you know the statics ahead of
time.

-Sara