Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103200
To: Andrey Andreev <narf@devilix.net>
Cc: Nicolas Grekas <nicolas.grekas@gmail.com>,
 PHP Internals List <internals@lists.php.net>
References: <CAOWwgpm83Vu3WmGKJrLJkAgU5pyyqtmV3nqZ6m6fHN7NAhoK=w@mail.gmail.com>
 <72a8942a-6f9b-8169-679c-39f03f175d32@gmx.de>
 <CAPhkiZwfwDnVg6gqXK39SePQgQpurQA+VDa-UwaO=7EC9LpSsw@mail.gmail.com>
Message-ID: <f34580f5-cdf7-26e5-8da7-4bfff28bd2ab@gmx.de>
Date: Thu, 20 Sep 2018 13:12:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <CAPhkiZwfwDnVg6gqXK39SePQgQpurQA+VDa-UwaO=7EC9LpSsw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: setcookie() doesn't follow the RFC in 7.3
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 20.09.2018 at 12:18,Andrey Andreev wrote:

> On Thu, Sep 20, 2018 at 12:12 PM, Christoph M. Becker <cmbecker69@gmx.de> wrote:
>
>> On 20.09.2018 at 08:15, Nicolas Grekas wrote:
>>
>>> yesterday I submitted https://bugs.php.net/76906 to report that I wasn't
>>> able to set the "samesite" attribute on cookies while I followed what's
>>> been approved in https://wiki.php.net/rfc/same-site-cookie
>>>
>>> Damian answered on the bug report that the $options argument has swallowed
>>> the lifetime one, so that $options is now the 3rd arg and not the 4th as
>>> noted in the RFC.
>>>
>>> He suggested me to raise the topic on internals, so here we are.
>>>
>>> Are we fine with this? If yes, shouldn't an errata be added to the RFC so
>>> that ppl aren't confused like I was?
>>
>> Related discussion: <https://externals.io/message/100304#102909>ff.
>>
>> Not sure if an errata (or amendment) should be added to the RFC, or
>> whether it is sufficient to document the new signatures in the manual
>> proper and the migration guide.
> 
> Since a PR with that change has been merged, apparently a side was
> chosen and so be it, I guess. But given all of the above, I think
> adding an errata to the RFC is the least that should be done.

The SameSite cookie attribute support has been documented[1], and an
errata section has been added to the RFC[2].

[1] <http://svn.php.net/viewvc?view=revision&revision=345661>
[2]
<https://wiki.php.net/rfc/same-site-cookie?do=diff&rev2%5B0%5D=1537441490&rev2%5B1%5D=1537441776&difftype=inline>

-- 
Christoph M. Becker