Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103194
To: Nicolas Grekas <nicolas.grekas@gmail.com>,
 PHP Internals List <internals@lists.php.net>
References: <CAOWwgpm83Vu3WmGKJrLJkAgU5pyyqtmV3nqZ6m6fHN7NAhoK=w@mail.gmail.com>
Message-ID: <72a8942a-6f9b-8169-679c-39f03f175d32@gmx.de>
Date: Thu, 20 Sep 2018 11:12:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <CAOWwgpm83Vu3WmGKJrLJkAgU5pyyqtmV3nqZ6m6fHN7NAhoK=w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: setcookie() doesn't follow the RFC in 7.3
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 20.09.2018 at 08:15, Nicolas Grekas wrote:

> yesterday I submitted https://bugs.php.net/76906 to report that I wasn't
> able to set the "samesite" attribute on cookies while I followed what's
> been approved in https://wiki.php.net/rfc/same-site-cookie
> 
> Damian answered on the bug report that the $options argument has swallowed
> the lifetime one, so that $options is now the 3rd arg and not the 4th as
> noted in the RFC.
> 
> He suggested me to raise the topic on internals, so here we are.
> 
> Are we fine with this? If yes, shouldn't an errata be added to the RFC so
> that ppl aren't confused like I was?

Related discussion: <https://externals.io/message/100304#102909>ff.

Not sure if an errata (or amendment) should be added to the RFC, or
whether it is sufficient to document the new signatures in the manual
proper and the migration guide.

-- 
Christoph M. Becker