Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103183
To: BohwaZ <php@bohwaz.net>, internals@lists.php.net
References: <381a49ae-eed5-889a-8d0c-bec4b4531d82@gmx.de>
 <20180919185324.6fdb080a@platypus>
Message-ID: <06392bc9-2acb-6992-f997-436b76a3eb92@gmx.de>
Date: Wed, 19 Sep 2018 19:41:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20180919185324.6fdb080a@platypus>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Unbundle libsqlite3?
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 19.09.2018 at 18:53, BohwaZ wrote:

> On Mon, 17 Sep 2018 15:16:13 +0200 / "Christoph M. Becker"
> <cmbecker69@gmx.de> said :
> 
>> ext/sqlite3 requires libsqlite ≥ 3.3.9[1] which has been released on
>> 2007-01-04[2] (i.e. more than eleven years ago!).  ext/pdo_sqlite has
>> no specific version requirement; there is a check for
>> sqlite3_open()[3] which I believe is available since 3.0.0.
> 
> I believe that SQLite3Stmt::readOnly requires SQLite 3.7.4 released in
> 2010, bundled since PHP 5.3.6 (!).

Ah, indeed[1]!

> There is also a PR patch (from me) that should make it in PHP 7.4 that
> implements this feature in pdo_sqlite too.

PR #2698[2] seems to require an RFC.  IMHO, it's best to present RFCs
and voting on them as early as possible (instead of rushing them at the
last moment). :)

> I believe this is the most recent feature that we are using. But it
> should return false if the SQLite version installed is older than that
> (IMHO it should throw an exception instead, but that's the current
> behaviour anyway).

I agree that an exception would be better.  A sensible alternative might
be to not even include the method for older libsqlite3.  Either way, a
PR targeting master would be welcome.

[1]
<https://github.com/php/php-src/blob/php-7.3.0RC1/ext/sqlite3/sqlite3.c#L1393-L1397>
[2] <https://github.com/php/php-src/pull/2698>

-- 
Christoph M. Becker