Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103182
Date: Wed, 19 Sep 2018 18:53:24 +0200
To: internals@lists.php.net
Message-ID: <20180919185324.6fdb080a@platypus>
In-Reply-To: <381a49ae-eed5-889a-8d0c-bec4b4531d82@gmx.de>
References: <381a49ae-eed5-889a-8d0c-bec4b4531d82@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Unbundle libsqlite3?
From: php@bohwaz.net (BohwaZ)

On Mon, 17 Sep 2018 15:16:13 +0200 / "Christoph M. Becker"
<cmbecker69@gmx.de> said :

> Hi!
>=20
> We bundle an unmodified libsqlite3 for at least two years.  Since then
> all updates go into any dev, alpha and beta releases, while security
> patches (usually backports from libsqlite3) go into stable branches.
>=20
> ext/sqlite3 requires libsqlite =E2=89=A5 3.3.9[1] which has been released=
 on
> 2007-01-04[2] (i.e. more than eleven years ago!).  ext/pdo_sqlite has
> no specific version requirement; there is a check for
> sqlite3_open()[3] which I believe is available since 3.0.0.

I believe that SQLite3Stmt::readOnly requires SQLite 3.7.4 released in
2010, bundled since PHP 5.3.6 (!).

There is also a PR patch (from me) that should make it in PHP 7.4 that
implements this feature in pdo_sqlite too.

I believe this is the most recent feature that we are using. But it
should return false if the SQLite version installed is older than that
(IMHO it should throw an exception instead, but that's the current
behaviour anyway).

As for bundling or not, I'm on Devuan and it is using the system
version of SQLite as far as I know so I don't see the need to bundle it
with PHP, but I don't have a good view of whether it might be needed on
other platforms.