Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:10318 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 66914 invoked by uid 1010); 8 Jun 2004 14:03:37 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 66888 invoked from network); 8 Jun 2004 14:03:37 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 8 Jun 2004 14:03:37 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.10/8.12.10) with ESMTP id i58E3ZH2028663; Tue, 8 Jun 2004 16:03:36 +0200 Date: Tue, 8 Jun 2004 16:03:19 +0200 (CEST) X-X-Sender: derick@localhost To: Alexander Valyalkin cc: internals@lists.php.net In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] stripslashes() improvements From: derick@php.net (Derick Rethans) On Tue, 8 Jun 2004, Alexander Valyalkin wrote: > Today I checked stripslashes() function. > My version of the function if faster, more clearer and bugs free (I hope > :)) You'll have to proof that by writing testcases, for example try it with the test cases in the current source and write new ones for things that we don't have a test case for yet. > -PHPAPI void php_stripslashes(char *str, int *len TSRMLS_DC) > +PHPAPI void php_stripslashes(char *str, size_t *len TSRMLS_DC) You can't just change the API call, that will break things. regards, Derick