Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103160
To: Theodore Brown <theodorejb@outlook.com>,
 Dan Ackroyd <danack@basereality.com>
Cc: PHP internals <internals@lists.php.net>
References: <7cf5adb8-0738-259e-6d1e-f966722fdae2@gmx.de>
 <CA+kxMuQRHq8HfuicqSFm8_Xcxw7VD6Aaqoi5TZa7m7Tofh1YKA@mail.gmail.com>
 <c2b8b875-f98e-1745-2ba8-ef7289a9c15f@gmx.de>
 <CY4PR18MB10489E50B61CC480A83B5853DE060@CY4PR18MB1048.namprd18.prod.outlook.com>
 <5ca1b295-6f43-794c-f2a9-f672155cc84c@gmx.de>
 <CY4PR18MB1048546563A670F0D2567C21DE1A0@CY4PR18MB1048.namprd18.prod.outlook.com>
Message-ID: <c1fe40dc-19a2-308a-0d5f-a4e9eeea9e22@gmx.de>
Date: Thu, 13 Sep 2018 18:41:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <CY4PR18MB1048546563A670F0D2567C21DE1A0@CY4PR18MB1048.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] fputcsv() and $escape character
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 13.09.2018 at 17:55, Theodore Brown wrote:

> On Thursday, September 13, 2018 at 7:30 AM Christoph M. Becker <cmbecker69@gmx.de> wrote:
> 
>> I've submitted <https://github.com/php/php-src/pull/3515>.
> 
> Thanks so much for your work on this! Do you know if the patch can be
> included in PHP 7.3?
> 
> If the patch was also applied to PHP 7.2 and 7.1, we wouldn't need to add
> fallback code in the League/Csv library for these versions. I understand
> if this isn't possible, but I'm trying to figure out how best to approach
> fixing the issue in League/Csv.

I'm afraid we can't even target PHP-7.3, let alone 7.2 or 7.1, since
feature freeze has long passed, and there are BC breaks as noted in the
commit message.  Sorry.

-- 
Christoph M. Becker