Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103159
To: "Christoph M. Becker" <cmbecker69@gmx.de>, Dan Ackroyd
	<danack@basereality.com>
CC: PHP internals <internals@lists.php.net>
Thread-Topic: [PHP-DEV] fputcsv() and $escape character
Thread-Index: AQHTMs79wIy3YRpng0yJQdwP3Tm59aK/1eiAgAGjXoCCKLn9mIAGIlQAgAA0K1Y=
Date: Thu, 13 Sep 2018 15:55:20 +0000
Message-ID: <CY4PR18MB1048546563A670F0D2567C21DE1A0@CY4PR18MB1048.namprd18.prod.outlook.com>
References: <7cf5adb8-0738-259e-6d1e-f966722fdae2@gmx.de>
 <CA+kxMuQRHq8HfuicqSFm8_Xcxw7VD6Aaqoi5TZa7m7Tofh1YKA@mail.gmail.com>
 <c2b8b875-f98e-1745-2ba8-ef7289a9c15f@gmx.de>
 <CY4PR18MB10489E50B61CC480A83B5853DE060@CY4PR18MB1048.namprd18.prod.outlook.com>,<5ca1b295-6f43-794c-f2a9-f672155cc84c@gmx.de>
In-Reply-To: <5ca1b295-6f43-794c-f2a9-f672155cc84c@gmx.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [iC9hnn4/mOuOmrshL6hhq4gidqxIY6ff]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;SN1NAM04HT160;6:z+0bCQ9cl8y9oz878CrB92DEg2XScG3Wfr5l3Bs04pKjYCOdqNYdfq2RTyvwEPJhWav3IKMu8ttJ1uLbHen+xOJJypfvv8mqGTtsSOJVjvQmvVz6yd/kSZA+eA1AVhh11D68FGU7fF9fO21L3nYHP69RhHdY5XJaJInBtA1lx3LkmHdOTI3QdSet6V7LaamZr5B9HYw8OlggUvdcPDJCyevgPsc0qdFMbe9Wmbt3gFKMCnPA7be0hII+lOyDTsN0QZmEAeI0wggO3HC8taRegIvYtAz0oRJQVfdSdhPm/tPTuJE+13V2GhgreBqb/ybB/o21oa8qPHYWVuAKKGKKnfBnYn5D7CBn4OyzKqSeTb25E/YMDFX9cva+IdfmEi7F5eoIS0EewOqxuCf0DMSZvmGvFCmIWbSjRTRvYcC9HMDtMIFYDlG/v24XXKATmw/VgkaI5NdmzQuYKPXeiQ8TRQ==;5:u+LaKMy2ctoAcdhLLiTeb1r3dJd99an7HHr89WjgP0d1E4vXKKpjj44XZXwuqYaKFA6GcjeGB4DfUZXQEzuX8BDN6gkPZ7kfNAUf8xnLPlS7BAumjrrpnGFDPzdtNEPQOK4FHjEnKOLjZRdnSmdY90LocxQu7yGo+N8SRy40WB8=;7:ADLGWjfljk6kCcyV2Lg5vwipFJcY5WArQ0A9f/2/sUA601lJWXGrbfWlveEC85dAFoe8+DckpSKVXhmB91h3RblZVzKn5baH01dARkVzGmTyhEF6R842J3zoMxrIaUMHqLe0uevicIUV+SJO9Ab0fqyXPYuJOy6E1LkUAGBFmRzxucXb2W+J8+J8Q2h9nThsNtBwHHR7ZM3uMthpF2NslW+etBnm7rY/JD5E2UCoYZD6ixkc2E2PFNVN45R8uLaf
x-incomingheadercount: 47
x-eopattributedmessage: 0
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101475)(1601125500)(1701031045);SRVR:SN1NAM04HT160;
x-ms-traffictypediagnostic: SN1NAM04HT160:
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(4566010)(82015058);SRVR:SN1NAM04HT160;BCL:0;PCL:0;RULEID:;SRVR:SN1NAM04HT160;
x-forefront-prvs: 07943272E1
x-forefront-antispam-report: SFV:NSPM;SFS:(7070007)(199004)(189003)(5250100002)(86362001)(81156014)(11346002)(486006)(476003)(99286004)(76176011)(74316002)(426003)(104016004)(56003)(4326008)(93886005)(305945005)(14454004)(966005)(2900100001)(97736004)(8676002)(446003)(5660300001)(87572001)(110136005)(26005)(8936002)(6346003)(256004)(53546011)(102836004)(68736007)(229853002)(20460500001)(33656002)(7696005)(82202002)(106356001)(6436002)(6306002)(55016002)(105586002)(6246003)(25786009);DIR:OUT;SFP:1901;SCL:1;SRVR:SN1NAM04HT160;H:CY4PR18MB1048.namprd18.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: outlook.com does not designate
 permitted sender hosts)
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=theodorejb@outlook.com; 
x-microsoft-antispam-message-info: Z9M3H8Apn4SaAOqRTfTZD3hIExqrz/p33XyxcOnlkyCiJpZzKDKvA8lLpQ1Rc9jzIKE9napxoCYaE1oRXF1nY3f76ThQOvGyYZ2pWYkH7LA0YpGpEFcOlc4jXxVN5rtgJNMs4Bx+7BCf7aYqqwBmyQBd1wu2MEigvit/fhEpMlBJHqXT4vCfds8fiEv4Sjnz2ksv0Gd6fUV4bJ0ixxIQggEduAJf/w2faAfuzzfkLj4=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: dd759f05-a917-4aa0-a2f5-4cc35c50e0c8
X-MS-Exchange-CrossTenant-Network-Message-Id: c7a365fe-7e67-4f3d-2919-08d619914f2d
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: dd759f05-a917-4aa0-a2f5-4cc35c50e0c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2018 15:55:20.7965
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM04HT160
Subject: Re: [PHP-DEV] fputcsv() and $escape character
From: theodorejb@outlook.com (Theodore Brown)

On Thursday, September 13, 2018 at 7:30 AM Christoph M. Becker <cmbecker69@=
gmx.de> wrote:=0A=
=0A=
>> Ironically, the League/Csv library uses `fputcsv()` behind the scenes,=
=0A=
>> and thus suffers from the same escape character problem=0A=
>> (see https://github.com/thephpleague/csv/issues/307).=0A=
>>=0A=
>> Is there any chance `fputcsv()` can be updated to allow setting a blank=
=0A=
>> string as the escape character? As Christopher pointed out, this would=
=0A=
>> not be a BC break, and while it wouldn't fix every issue with the=0A=
>> function it would still be a step forward. Frankly I found it very=0A=
>> surprising that the function *didn't* support passing a blank string.=0A=
>=0A=
> I've submitted <https://github.com/php/php-src/pull/3515>.=0A=
=0A=
Thanks so much for your work on this! Do you know if the patch can be=0A=
included in PHP 7.3?=0A=
=0A=
If the patch was also applied to PHP 7.2 and 7.1, we wouldn't need to add=
=0A=
fallback code in the League/Csv library for these versions. I understand=0A=
if this isn't possible, but I'm trying to figure out how best to approach=
=0A=
fixing the issue in League/Csv.=