Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103134
To: Derick Rethans <derick@php.net>
CC: PHP Developers Mailing List <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: Mysterious (to me) Xdebug issue with PHP 7.3
Thread-Index: AQHURGwXo94tZNIDxEqRrFlryqZ97qThNe6mgAA2rgCAABLjtoAAkGTB
Date: Wed, 5 Sep 2018 19:12:45 +0000
Message-ID:
 <BY1PR02MB1260A910CA056415E54C5BF7BF020@BY1PR02MB1260.namprd02.prod.outlook.com>
References:
 <alpine.DEB.2.21.1809041724430.10075@singlemalt.home.derickrethans.nl>
 <BY1PR02MB1260E29E9846B53CF8B421AABF020@BY1PR02MB1260.namprd02.prod.outlook.com>,<alpine.DEB.2.21.1809051017030.3099@singlemalt.home.derickrethans.nl>,<BY1PR02MB1260CDAC4C39154837064311BF020@BY1PR02MB1260.namprd02.prod.outlook.com>
In-Reply-To:
 <BY1PR02MB1260CDAC4C39154837064311BF020@BY1PR02MB1260.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY1PR02MB1260A910CA056415E54C5BF7BF020BY1PR02MB1260namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c30c564-8a3a-4e34-bce0-08d613638fc8
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2018 19:12:45.2739
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR02MB1225
Subject: Re: [PHP-DEV] Re: Mysterious (to me) Xdebug issue with PHP 7.3
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY1PR02MB1260A910CA056415E54C5BF7BF020BY1PR02MB1260namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

I hope, it's fixed now.

Please verify.


Dmitry.

________________________________
From: Dmitry Stogov <dmitry@zend.com>
Sent: Wednesday, September 5, 2018 1:36:33 PM
To: Derick Rethans
Cc: PHP Developers Mailing List
Subject: Re: [PHP-DEV] Re: Mysterious (to me) Xdebug issue with PHP 7.3

I see the problem, and most probably, it has to be fixed in PHP sources.

I'll try to take a deeper look today evening.


Thanks. Dmitry.

________________________________
From: Derick Rethans <derick@php.net>
Sent: Wednesday, September 5, 2018 12:27:56 PM
To: Dmitry Stogov
Cc: PHP Developers Mailing List
Subject: [PHP-DEV] Re: Mysterious (to me) Xdebug issue with PHP 7.3

Hi,

in Xdebug, I do supply my own opcode handlers for quite a few opcodes,
including ZEND_IS_EQUAL, and a whole bunch of others. Is it possible
that when you use zend_set_user_opcode_handler[1][2] that this swap
isn't done with zend_swap_operands? My opcode handler basically just
does some code and then uses ZEND_VM_DISPATCH[3].

[1] https://github.com/derickr/xdebug/blob/PHP-7.3-support/xdebug_code_cove=
rage.h#L47-L48
[2] https://github.com/derickr/xdebug/blob/PHP-7.3-support/xdebug.c#L781
[3] https://github.com/derickr/xdebug/blob/PHP-7.3-support/xdebug_code_cove=
rage.c#L125-L142

cheers,
Derick

On Wed, 5 Sep 2018, Dmitry Stogov wrote:

> Hi Derick,
>
>
> The message "Invalid opcode 17/1/8" means that PHP doesn't have handler f=
or opcode 17 (ZEND_IS_EQUAL) where first operand IS_CONST and second operan=
d IS_CV.
>
>
> ZEND_IS_EQUAL is a commutative operator. zend_vm_gen.php doesn't generate=
 code for ZEND_IS_EQUAL_SPEC_CONST_CV_HANDLER, but PHP code-generator swaps=
 operands, if necessary, to use ZEND_IS_EQUAL_SPEC_CV_CONST_HANDLER.
>
>
> ZEND_API void ZEND_FASTCALL zend_vm_set_opcode_handler(zend_op* op)
> {
>     zend_uchar opcode =3D zend_user_opcodes[op->opcode];
>     uint32_t spec =3D zend_spec_handlers[opcode];
>
>     if (spec & SPEC_RULE_COMMUTATIVE) {
>         if (op->op1_type < op->op2_type) {
>             zend_swap_operands(op);
>         }
>     }
>     op->handler =3D zend_vm_get_opcode_handler_ex(spec, op);
> }
>
>
> I have no idea, why PHP with xdebug doen't swap operands.
>
>
> Thanks. Dmitry.
>
> ________________________________
> From: Derick Rethans <derick@php.net>
> Sent: Tuesday, September 4, 2018 7:26:49 PM
> To: Dmitry Stogov
> Cc: PHP Developers Mailing List
> Subject: Mysterious (to me) Xdebug issue with PHP 7.3
>
> Hi,
>
> I'm finalizing Xdebug support for PHP 7.3, and although I have fixed
> many things, there is one thing that is (currently) eluding me.
>
> The branch I'm working on is
> https://github.com/derickr/xdebug/tree/PHP-7.3-support
>
> With Xdebug (just) loaded, the following script:
>
>         $ cat /tmp/bug01471.php
>         <?php
>         $c =3D "aa" =3D=3D $ff ? 1 : 0;
>         ?>
>
> Fails to run with:
>
>         $ php -n -dzend_extension=3Dxdebug.so /tmp/bug01471.php
>
>         Fatal error: Invalid opcode 17/1/8. in /tmp/bug01471.php on line =
2
>
>         Call Stack:
>             0.0002          0   1. {main}() /tmp/bug01471.php:0
>
> I also see others, like when running with a Composer library:
>
>         $ vendor/bin/phpunit --debug
>
>         Fatal error: Invalid opcode 16/1/2. in /home/derick/dev/php/deric=
kr-mongo-php-library/vendor/composer/autoload_real.php on line 18
>
>         Call Stack:
>             0.0003     431424   1. {main}() /home/derick/dev/php/derickr-=
mongo-php-library/vendor/phpunit/phpunit/phpunit:0
>             0.0005     433616   2. require('/home/derick/dev/php/derickr-=
mongo-php-library/vendor/autoload.php') /home/derick/dev/php/derickr-mongo-=
php-library/vendor/phpunit/phpunit/phpunit:51
>             0.0008     450432   3. ComposerAutoloaderInit96731179a4aab683=
8b54de3a71995ee1::getLoader() /home/derick/dev/php/derickr-mongo-php-librar=
y/vendor/autoload.php:7
>
> And I can't figure out why. The backtrace isn't particularly useful
> either. I got similar issues with get_zval_ptr [1], as it changed, but I
> can't track this specific one down. Would you mind having a look?
>
> cheers,
> Derick
>
> [1] https://github.com/derickr/xdebug/commit/70d9189700d57707d842020493a3=
df23e0c76098
> --
>
>
> --
> https://derickrethans.nl | https://xdebug.org | https://dram.io
> Like Xdebug? Consider a donation: https://xdebug.org/donate.php,
> or become my Patron: https://www.patreon.com/derickr
> twitter: @derickr and @xdebug
>

--
https://derickrethans.nl | https://xdebug.org | https://dram.io
Like Xdebug? Consider a donation: https://xdebug.org/donate.php,
or become my Patron: https://www.patreon.com/derickr
twitter: @derickr and @xdebug

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php


--_000_BY1PR02MB1260A910CA056415E54C5BF7BF020BY1PR02MB1260namp_--