Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:103121 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 67212 invoked from network); 4 Sep 2018 14:17:50 -0000 Received: from unknown (HELO mout.gmx.net) (212.227.15.15) by pb1.pair.com with SMTP; 4 Sep 2018 14:17:50 -0000 Received: from [192.168.2.133] ([91.8.166.159]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MYOY5-1gS9ov3Tfd-00V6W6; Tue, 04 Sep 2018 12:20:24 +0200 To: Kalle Sommer Nielsen , Internals References: Message-ID: <1e192647-2786-2d5e-946a-620cdeef5f55@gmx.de> Date: Tue, 4 Sep 2018 12:20:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:8vyo2nLGX+8XL5ck3Iv8ouEwCknaS62S2EBZFouhaLmxCBhbBRT UmbHIfjYnsl/VMvXpcbDIS9v4WNCupxPfu6H2VA7obXpS1EwE5e19gD3/vF2jjgvgBBZyWf bhe2fhnEyha1upALqAZyM78kKGD3f70x5k1pVqrrhHQgu3F+JZzVXZo7bZQZ9xiN3oV78Cp moP/3tx7FzzSmLeEaeoJw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Rm8d/sC6B2Q=:hTxigrPSRU0bDrb1+fTm0X C+IyUpBuDjqyXu34XIJm39xaZa5pFtN7dkaG/eHFCh11lano8Sat6HKPR9P4PNvkiBQt+6MjV pZvXRX87qul5V7hcjT/oshnamIh81xk9NA4y9GwM+lgEeD/FlVZrlBPyqzW86feqH1rQT1kpB jsUS+fFuKjCOZuBl6c0T7k+gIBsJ4EImWGRyYK0joU7aZ0t80Km4Laa0gUpso1ArX8YcPAvZk CJDGeReI9TrQr6fKSROuIOPprTB2jVK36bPx5yMYizoiV02Ln8NtQ5ehJDo8z+TDKhbSlYRQ7 5sDbg/uhwwNUdJPqMw0jZfRbTVhI3vyPspHRBRcOAII7bXbzsfa7uGXwLm9jWXsSmVQVXHiAx TNjlXCsh5CLG8JI+w+sNtCWktfJA5/fLrwnikHdQMU8Eaj/KhJVPc2w1t3uSmqV+zZWcF73ri 1NeP1wJIeFOE3gLPnRNKDefqr1nUK3nWPlHqYoow+yA200KQrx1Lkln1rTJVqK6pduqe6O6As QlKBkaJiyYCC+ld6fzzRnCw0W+/j8zaKratOcVVSJjFCjrMR4v88+01h637mqNWHDtousV8Xj Q4tnXmXS5s192D/wZXBfP2A91AFNGdWmSr48pgnelGoHORx2c6Hp8nASOZMEWqt1dDGBATZcu i4BOQf7A6x/r9BYmdlfA7OZYRict04E4pohlUHPRON3MbZd+QrbLeldnAy4lCbu9ZZrxVNQ4Q gjBTgx8P18n1NLkYyIT2l7R/xWgpbFXg/nEahqlCLJKdnT5iux5Q5ZmBbu8F2B/6byox9bVRX VkHJvES Subject: Re: RFC Proposal: Make the hash extension always available From: cmbecker69@gmx.de ("Christoph M. Becker") On 04.09.2018 at 11:11, Kalle Sommer Nielsen wrote: > I just posted an RFC and set it up for discussion[1], this proposes to > make the ext/hash extension always enabled, similar to that for date, > spl & pcre. > > Comments are welcome. I intend to start voting in 2-3 weeks time, > should there be no critical issues in regards to this RFC. > > > [1] https://wiki.php.net/rfc/permanent_hash_ext That appears to be sensible. Anyhow, *if* we do this, we also should move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and SHA1 is currently dead code in ext/hash, and the CRC32 implementation seems to be duplicated). We should also have a look at crypt_sha256.c and crypt_sha512.c (of ext/standard) which likely duplicate some code already available in ext/hash. -- Christoph M. Becker