Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103092
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.54 as permitted sender)
MIME-Version: 1.0
References: <CAOg_pRQM_y4kU7bsDjHMnr-K07nhPKNDkdiE895-5Wrf_Huzog@mail.gmail.com>
 <CAF+90c9STh1QnamNmxfopZbR8OXSjbk4SXpNrPAYnBXU=ys15g@mail.gmail.com>
In-Reply-To: <CAF+90c9STh1QnamNmxfopZbR8OXSjbk4SXpNrPAYnBXU=ys15g@mail.gmail.com>
Date: Mon, 13 Aug 2018 16:03:06 +0200
Message-ID: <CAOg_pRTmxF6T6nu1z-d4+sQaEgYR0rvyt2f2iW0dfBHNXytKfg@mail.gmail.com>
To: nikita.ppv@gmail.com
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001c465a0573518ecf"
Subject: Re: [PHP-DEV] object destruction php 5.6 vs. 7.2
From: nicolai.scheer@gmail.com (Nicolai Scheer)

--0000000000001c465a0573518ecf
Content-Type: text/plain; charset="UTF-8"

Hi Nikita,

On Sat, 11 Aug 2018 at 11:03, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Wed, Aug 8, 2018 at 11:09 PM, Nicolai Scheer <nicolai.scheer@gmail.com>
> wrote:
>
>> [resource destructor does not get called until shutdown]
>
>
> My guess would be some kind of refcounting issue. For example
> zend_update_property will already increment the refcount of the assigned
> value itself. So if you create a value with refcount 1 and then assign it
> to an object property, you likely need to do an explicit delref. If you
> don't, then the value is leaked and your resource destructor will not run
> until shutdown.
>
>
Yes, you're absolutely right.

I switched from:

zval *rsrc = NULL;
rsrc = zend_list_insert( conn_data, le_wmqe_connection_rc );
zend_update_property( php_wmqe_connection_entry, getThis(), "connection",
sizeof( "connection" ) - 1, rsrc );

to:

zend_resource *rsrc = NULL;
rsrc = zend_register_resource( conn_data, le_wmqe_connection_rc );
add_property_resource( getThis(), "connection", rsrc );

Now the refcounting seems to be appropriate and the resource dtor gets
called on object destruction.

I guess it would be better to leave resources all alone and switch to
custom object storage for that matter...

Thanks!

Greetings

Nico

--0000000000001c465a0573518ecf--