Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103079
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.19 as permitted sender)
To: "Jesse G. Donat" <donatj@gmail.com>, internals@lists.php.net
References: <CAFDBR4aty-Z48kdibfogxf12PLrMphLm53RLD7ekWjG9w9nZZg@mail.gmail.com>
Message-ID: <72f6c9c7-10e4-c616-5d1e-7d998e7cc4bb@gmx.de>
Date: Sat, 11 Aug 2018 14:30:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <CAFDBR4aty-Z48kdibfogxf12PLrMphLm53RLD7ekWjG9w9nZZg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: RFC Proposal
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 10.08.2018 at 22:15, Jesse G. Donat wrote:

> I'm measuring reaction for an RFC
> 
> Essentially right now preg regex's fail silently - and you have to
> actually check them manually with preg_last_error - something I've
> never actually seen done in code.
> 
> see:
> 
> https://github.com/php/php-src/pull/2910
> https://bugs.php.net/bug.php?id=70110
> https://bugs.exim.org/show_bug.cgi?id=1663
> 
> I'd like to propose that, in line with the recent JSON changes, the
> preg methods be made to throw exceptions (or at the very least -
> warnings) rather than fail silently as I believe this is a bad
> behaviour.
> 
> I personally do not have the low level coding knowledge needed to do
> this, nor do I personally know anyone who does, so I would be
> submitting this as a "concept"
> 
> 
> Thank you ahead of time!
> 
> This will be my first RFC submission, so I hope I'm doing this right.

Thanks for bringing this up.  In principle, I'd like better feedback for
failing PCRE functions, but I'm rather concerned regarding the BC break.
 For json_(en|de)code() it was simple to just add another option flag,
but some of the PCRE functions (e.g. preg_replace()) do not have an
$options/$flags parameter yet, but already too many (optional)
parameters.  Perhaps it would be best to postpone this to PHP 8, where
additional warnings, and maybe even exceptions, would be acceptable.

Anyhow, the implementation might be as simple as
<https://gist.github.com/cmb69/a9c65af3a1462ed21b12beace502de0d>.

-- 
Christoph M. Becker