Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:103066
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.208.177 as permitted sender)
MIME-Version: 1.0
References: <CAO7eTqNs_fjkR_U5bfOWh65U+eyGTNLjDWGK9J62+FtdThOMDw@mail.gmail.com>
 <CAESVnVoyrTmA-+0PpCaxNmNF36OA+WP4x3O-3piw86yNrLzfyg@mail.gmail.com>
In-Reply-To: <CAESVnVoyrTmA-+0PpCaxNmNF36OA+WP4x3O-3piw86yNrLzfyg@mail.gmail.com>
Date: Wed, 8 Aug 2018 13:39:13 -0600
Message-ID: <CAFMT4NoCRrcKrWwVLRZo_QBxRToy=S9ACC=9vJUaYQ6cW6kYMA@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: php.net@majkl578.cz, internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Eligibility of array_key_exists() optimization for 7.3
From: levim@php.net (Levi Morrison)

On Wed, Aug 8, 2018 at 12:50 PM Sara Golemon <pollita@php.net> wrote:
>
> On Wed, Aug 8, 2018 at 12:11 PM, Michael Moravec <php.net@majkl578.cz> wrote:
> > Do you think this optimization could still go into 7.3 so the PHP ecosystem
> > could benefit from this improvement (possibly could be reverted in case of
> > issues)?
> >
> My vote is no.
>
> It's an optimization and optimizations are yay, but feature freeze
> isn't just a PR label, it's a release process milestone.  The tradeoff
> against code-stability just isn't there.
>
> -Sara
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php

I agree with Sara. Sadly, I also have some similar improvements I
wanted to get in for improving the performance of `array_slice` but
couldn't meet feature freeze. If we were to bring in my changes and
yours and who knows who else may have lurking changes like this then
the stability risk Sara mentioned is real.

It hurts to wait for another release but the bright side is that is a
lot of time for the feature to get tested and be far less risky.