Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102974 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86780 invoked from network); 25 Jul 2018 22:24:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Jul 2018 22:24:49 -0000 Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.173 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.220.173 mail-qk0-f173.google.com Received: from [209.85.220.173] ([209.85.220.173:43238] helo=mail-qk0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 61/E1-12660-0B8F85B5 for ; Wed, 25 Jul 2018 18:24:48 -0400 Received: by mail-qk0-f173.google.com with SMTP id z74-v6so5980239qkb.10 for ; Wed, 25 Jul 2018 15:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=jnzGivEl+9xq7SaJ+NXP/NXy1HnibKPmnA1uChsFaIE=; b=zN8U2YPll19qMCxwWD4nMXveRBqvBSNEsmZ8Yk6OjL2Uow6iBeNoWDNBcnRF8sf2iI qmadPacGiyv6KkC6QZN3Q/Ffgw3YFhY2/qXFwPKKmn65skNxt0cKhdXXpN9lXG0TlZSG j44LQmvCYAa9RpE4SVykRLtVt0jWxV6SY5Lj1uZvwJ6DxEm6wzZKRq5bTVcUJFJtL1f/ 0lcek3jREAePc93dCDkO8oH/AOjsFavz8UXdh3zMunTyHic/CMj6PqlkP87AQiaPrJz0 yPn5J9OHWJVghN7FKcaeYzCWW3b0sFOO2v1inXumM4dhx/5SLmJoIJkDq3SQUfv+0VdL Y8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=jnzGivEl+9xq7SaJ+NXP/NXy1HnibKPmnA1uChsFaIE=; b=ZX4sS0jqJTl5LPWiqLPsn47O+oz1B/naLZKrk4h0+iJgFkSx1xPu9lpzstC+PYK4V/ 8V+CSNuONz7pmjoDjWm8pqAwQKE02SiOW7uQiLfjgudNrYexcKqu5PhwV7EQf3zOikRp xu9kbJhjURn8Rg/jGa1Si2kERc3cvtFBBtyy9/AHFgtK6BpvW3IaYCo/DCTxHgyT4eav ZXcmJ2OXOs5bbDUN7iBh+mLLIlSkCidi9rSZnUuarKHyNX0oQ8c3Dq+JO7KxVBcA6nZ8 QW2+nmqdt41Gqmfg2Z57kWzJGES7m1BGxKA5DpmPzDL2nmiBVRtbNqPl4XPv0bRCOgcC +xZg== X-Gm-Message-State: AOUpUlFdbhBn7DxAqeBUqqezGFfM0AzstVPbwzgeKbn9u1lgkH74ky4g pEZlLbu2gCq1d2/1J4kpB4ptVkK3nSsVw9y++ugOiQ== X-Google-Smtp-Source: AAOMgpf+rZsqHYHeyg+RgGZWbodh6Vav/z+poR+ipDfPDghgWrzq9ZeKmD7Ah3hzson962a7jWsH1w8BFsrlNapg+EY= X-Received: by 2002:a37:9e17:: with SMTP id h23-v6mr20383211qke.269.1532557485989; Wed, 25 Jul 2018 15:24:45 -0700 (PDT) MIME-Version: 1.0 Sender: php@golemon.com Received: by 2002:a0c:ada6:0:0:0:0:0 with HTTP; Wed, 25 Jul 2018 15:24:45 -0700 (PDT) X-Originating-IP: [73.210.228.160] In-Reply-To: References: Date: Wed, 25 Jul 2018 18:24:45 -0400 X-Google-Sender-Auth: yjdZSK6lqhUDJOaryvCmffjZl9k Message-ID: To: Dmitry Stogov Cc: Stanislav Malyshev , "Christoph M. Becker" , PHP internals list , Nikita Popov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] ZEND_ACC_* flags From: pollita@php.net (Sara Golemon) On Wed, Jul 25, 2018 at 11:01 AM, Dmitry Stogov wrote: > > I tried to fix ZEND_ACC_* flags mess. > > https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1 > > > The patch specifies flags meaning, and reorder them according to meaning = and frequency of usage (this allows generation of shorter instructions on x= 86). > Unfortunately, the patch breaks few reflection based tests that relay on = binary modifiers values. > Documentation part: LOVE =F0=9F=92=96 LOVE =F0=9F=92=96 LOVE Renumbering part: Eh, could save that for 8.0, but I won't complain about it in 7.4. Whichever version it lands in, please make a bump to ZEND_MODULE_API_NO part of the commit, and a comment in UPGRADING.INTERNALS as well. -Sara