Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:102973 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80905 invoked from network); 25 Jul 2018 20:09:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Jul 2018 20:09:55 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain zend.com from 104.47.36.129 cause and error) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 104.47.36.129 mail-sn1nam02on0129.outbound.protection.outlook.com Received: from [104.47.36.129] ([104.47.36.129:48832] helo=NAM02-SN1-obe.outbound.protection.outlook.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4F/31-12660-D09D85B5 for ; Wed, 25 Jul 2018 16:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=RWSoftware.onmicrosoft.com; s=selector1-zend-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FU8Z7TbScQaLIHzH25mxkRFBOohVKx0ZbYlh+7Sh/j0=; b=xBxAVpWpEt4LVf5GvwiGn0C/6tTJ+AZoFsKL6fdoCM0MHBpk6Cqjyk9KvL84xnki0/uUGog1jt/04pPRCdxWlVwEhHG+I7RQ+Q11PYjKjOlNlInZQCI9uNqmVLJQ9Pe0Yo6WyIcjPaXBpotaVtw4nPZoIV8MIyZirhSG+GyTP+s= Received: from BY1PR02MB1260.namprd02.prod.outlook.com (10.162.109.14) by BY1PR02MB1114.namprd02.prod.outlook.com (10.162.108.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Wed, 25 Jul 2018 20:09:45 +0000 Received: from BY1PR02MB1260.namprd02.prod.outlook.com ([fe80::a5a0:58d3:33f4:57b5]) by BY1PR02MB1260.namprd02.prod.outlook.com ([fe80::a5a0:58d3:33f4:57b5%4]) with mapi id 15.20.0973.022; Wed, 25 Jul 2018 20:09:44 +0000 To: Stanislav Malyshev , "Christoph M. Becker" , PHP internals list CC: Nikita Popov Thread-Topic: ZEND_ACC_* flags Thread-Index: AQHUJCb7q2GbhDZpFkSMiodris+09qSgRCKAgAAYyAY= Date: Wed, 25 Jul 2018 20:09:44 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dmitry@zend.com; x-originating-ip: [212.232.72.197] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY1PR02MB1114;6:BwbWBQW28KKWRjgHxbFtvIi/RS+6ALJLJ09PJhRQ0J0xuPZJzti+13Kddj4JMT39Kvh8iBG0O0UlONqXIvuyEeC3Tw6TZHOgSKWqds3gVtgJkOTOX1K8B2zEYa9SiD4iKuH40hVpUgVm/5osFN4UUARvS5EtneKB9zEwXXlsYZ0F07l9SdwivSZpVYSsFKoJpajSer+O5BmuSh9CKfAoI4+7cm2R6HugkJdE0Pvnu0DdfwCRjAfI/zgr2aWb497U+itMcu/vn8KjnGhp1tMmCg7a8sV1i0SdnyQhPQ9PGyQrkQI4/vDkTdH9bXJ/A8FiKzXwfzWvjnGmbvpdfy8jv4l+Tp9fSefJQZfvbEHY76PES90Qk5L7e38e40aEfTY0X36Hovj2qGJGea57pZVgTQCLJ9bOLeRpCyXHm89fZOJw+ID55VUBP6IEPWaDms5xf5Os3M9MOgcevygKWmOrZA==;5:K5fVJguG6fWBaPdBEOQJMGGcsUEU9pSS/NpgbMwell3Sy7R9WyW41wkB10Hhww1ZgJP724yAkR0qZLNhtJI7QngV0NdwUN1dgZLjocBhmaPEOMAsBcb9CuZdkzWAzWVACvw0eWVPbza+fPnImA1ifPmGYcYvoBzSaOXOZY0A5zU=;7:rcnLeHz+ID9av73EkiK/eACvENZJQPSutyY2ZaJlZZpB6PTM21EdqWVD1GM5sNcSARHXNZxVOsly9wsVNNpHGmln5RnfAVwjCH92BXcezEVQtZgVen3n0qBoqzezwytFwQ8spIr0aszi3v5J1DYdje3dH3cHjX6OrWrqRCmoLdgJN/jtdbjyeNaqUi/ORxHNOO7N+wzP6OjmKwPeiFpzCdehCCNyN8+1IxVUDypx4plZm9dIoqAavQr7nP8ePXlz x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: f8599c00-ce65-409b-6d36-08d5f26a9089 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:BY1PR02MB1114; x-ms-traffictypediagnostic: BY1PR02MB1114: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(244540007438412)(166708455590820)(85827821059158)(192278398808882); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:BY1PR02MB1114;BCL:0;PCL:0;RULEID:;SRVR:BY1PR02MB1114; x-forefront-prvs: 0744CFB5E8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(136003)(39850400004)(376002)(346002)(396003)(189003)(199004)(478600001)(486006)(86362001)(966005)(476003)(53936002)(8936002)(5660300001)(11346002)(2900100001)(55016002)(446003)(236005)(5250100002)(54896002)(6606003)(6306002)(4326008)(25786009)(68736007)(39060400002)(9686003)(6436002)(6246003)(14454004)(99286004)(33656002)(186003)(6506007)(26005)(106356001)(105586002)(7736002)(53546011)(81166006)(606006)(102836004)(97736004)(19627405001)(2906002)(81156014)(7696005)(8676002)(110136005)(66066001)(256004)(6116002)(74316002)(229853002)(3846002)(316002)(76176011);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR02MB1114;H:BY1PR02MB1260.namprd02.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: zend.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: mh7iPsg2J42IFYXHWOkmzZSQ+V432dnbUKUoBYC8tq1k608t3uIS153xgK+BlI8gnVHX/i7OjtxAyRD+Sm20aGzZ3bHY5Pa/rYyy529z8rdpscSGSHT0BjYWBSlNiASpf/NS6HBHvI7OYsg2E11uw4Him5K8L6/ObqD+jWn9RRuhpowwl+TCCk6LfE8Q2LuL5Moi+Ab7nXP5ax71VQiwB+OaVeNV4IC0JM13K2VPLYZFJ9EkXDvXMMv3Rh/S+Sln2A13LLzIWfghB58r9fCHlFTV7dp3DBMVe4+hTtLI6b9pihktbNb5+gbCJ4nq3bvEFIogN78WoLHwtmHmaCbXGkz3+oBjMqIIhAhRvWDBwyI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/alternative; boundary="_000_BY1PR02MB1260A6187B2BD3994644B903BF540BY1PR02MB1260namp_" MIME-Version: 1.0 X-OriginatorOrg: zend.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8599c00-ce65-409b-6d36-08d5f26a9089 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2018 20:09:44.6767 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR02MB1114 Subject: Re: ZEND_ACC_* flags From: dmitry@zend.com (Dmitry Stogov) --_000_BY1PR02MB1260A6187B2BD3994644B903BF540BY1PR02MB1260namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. I'll keep this for next PHP version. There is no any performance improvement (just a bit smaller code). The patch clarifies the meaning of all the flags, what entities use them, a= nd points what some of them may be eliminated completely. Thanks. Dmitry. ________________________________ From: Stanislav Malyshev Sent: Wednesday, July 25, 2018 9:35:11 PM To: Dmitry Stogov; Christoph M. Becker; PHP internals list Cc: Nikita Popov Subject: Re: ZEND_ACC_* flags Hi! > I tried to fix ZEND_ACC_* flags mess. > > > https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1 > > > The patch specifies flags meaning, and reorder them according to meaning > and frequency of usage (this allows generation of shorter instructions > on x86). > > Unfortunately, the patch breaks few reflection based tests that relay on > binary modifiers values. I am not sure I understand what the effect is here - does it allow any measurable improvement? If not, I'd wait until the after the branch. But I could change my mind if there's real performance gain... The test part, however, which replaces bits with constants, I think is good anytime, I don't think we should have been using bit values anyway. -- Stas Malyshev smalyshev@gmail.com --_000_BY1PR02MB1260A6187B2BD3994644B903BF540BY1PR02MB1260namp_--