Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102971
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.41 as permitted sender)
MIME-Version: 1.0
References: <BY1PR02MB1260DC6B3084565233993467BF540@BY1PR02MB1260.namprd02.prod.outlook.com>
In-Reply-To: <BY1PR02MB1260DC6B3084565233993467BF540@BY1PR02MB1260.namprd02.prod.outlook.com>
Date: Wed, 25 Jul 2018 20:27:49 +0200
Message-ID: <CADyq6sKKfQqzwq+fS7v2MmR3+xCT8-_LA+C7-rBQfMEfdneS0A@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, "Christoph M. Becker" <cmbecker69@gmx.de>, 
	PHP internals list <internals@lists.php.net>, Nikita Popov <nikic@php.net>
Content-Type: multipart/alternative; boundary="000000000000e5f3fe0571d70941"
Subject: Re: [PHP-DEV] ZEND_ACC_* flags
From: ocramius@gmail.com (Marco Pivetta)

--000000000000e5f3fe0571d70941
Content-Type: text/plain; charset="UTF-8"

This can potentially break some cached flags somewhere, and is a BC break:
any rationale behind the change?

On Wed, 25 Jul 2018, 17:01 Dmitry Stogov, <dmitry@zend.com> wrote:

> Hi,
>
>
> I tried to  fix ZEND_ACC_* flags mess.
>
>
> https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1
>
>
> The patch specifies flags meaning, and reorder them according to meaning
> and frequency of usage (this allows generation of shorter instructions on
> x86).
>
> Unfortunately, the patch breaks few reflection based tests that relay on
> binary modifiers values.
>
>
> Do you think, it it's OK to commit thin into 7.3 or better to wait for
> branching?
>
>
> Thanks. Dmitry.
>

--000000000000e5f3fe0571d70941--