Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:10296 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88543 invoked by uid 1010); 7 Jun 2004 14:19:07 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 88518 invoked from network); 7 Jun 2004 14:19:06 -0000 Received: from unknown (HELO asuka.prohost.org) (24.100.195.79) by pb1.pair.com with SMTP; 7 Jun 2004 14:19:06 -0000 Received: (qmail 15426 invoked from network); 7 Jun 2004 14:19:05 -0000 Received: from rei.nerv (HELO dummy.com) (rei@192.168.1.1) by asuka.nerv with SMTP; 7 Jun 2004 14:19:05 -0000 Reply-To: ilia@prohost.org To: internals@lists.php.net, "Alexander Valyalkin" Date: Mon, 7 Jun 2004 10:19:09 -0400 User-Agent: KMail/1.6.1 References: In-Reply-To: Organization: Prohost.org MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Message-ID: <200406071019.09059.ilia@prohost.org> Subject: Re: [PHP-DEV] readfile() improvements From: ilia@prohost.org (Ilia Alshanetsky) IMO Adding additional error reporting is a good idea, but we should keep MAP_SHARED as the mmap mode. In Apache environment if the file is mapped by more then one process the memory needed to map the file is shared, rather then each fork allocating it's own copy. Unless we decide to make this a SAPI based option, I think we should keep it at MAP_SHARED. Ilia