Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102958
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.51 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <CANUQDCh7NWMNniByMj=poc1KtChjH9KABZ8qw7KxRxjZx4NwDA@mail.gmail.com>
References: <8bb21db9-1f64-6520-68af-23840bba77ea@snowgarden.ch>
 <CAEKnhAHWhZ+EghPv5BGhSLpk5FDme3aHB9-w5=AO+bY1WUJhtg@mail.gmail.com> <CANUQDCh7NWMNniByMj=poc1KtChjH9KABZ8qw7KxRxjZx4NwDA@mail.gmail.com>
Date: Sun, 22 Jul 2018 19:52:35 +0100
Message-ID: <CAEKnhAGYK_1pcDPgkmS4KJotQaoEDEP=xPYxSuyR23ar7fsUDg@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>
Cc: Dominic Luechinger <dol+php@snowgarden.ch>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004869f105719b085b"
Subject: Re: [PHP-DEV] Improvements to openssl_crs_new. Need advice
From: bukka@php.net (Jakub Zelenka)

--0000000000004869f105719b085b
Content-Type: text/plain; charset="UTF-8"

On Thu, Jul 19, 2018 at 9:36 PM, Niklas Keller <me@kelunik.com> wrote:

> Hey,
>
> I'd prefer a proper OO API in case we add new features in that area.
>

It would be nice but it's much more work as it would require quite a bit of
changes in all csr functions and to make it consistent with other bits, we
should also introduce objective API for other parts like x509. So unless
you volunteer to do all the work anytime soon, I don't think we can have
this as a requirement.

I think it's actually still ok to accept any extending of the current
functions because some parts of the implementation and tests could be then
useful when when moving to the objective API and until then the
functionality will be at least available to users.

It might be also possibly that someone will do it all in PHP once the FFI
is in (basically in kind of the same way as pyca cryptography) but that
might take some time too...

Cheers

Jakub

--0000000000004869f105719b085b--