Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102955
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.20 as permitted sender)
To: Niklas Keller <me@kelunik.com>, =?UTF-8?Q?Pedro_Magalh=c3=a3es?=
 <mail@pmmaga.net>
Cc: Andrey Andreev <narf@devilix.net>, Frederik Bosch <f.bosch@genkgo.nl>,
 Stanislav Malyshev <smalyshev@gmail.com>,
 PHP Internals <internals@lists.php.net>
References: <a4189866-23ea-4dc5-12a4-a7fbad8e5601@genkgo.nl>
 <1abd260d-ebc4-a062-3381-72485946e8bc@gmail.com>
 <a55b37e3-268c-f8ab-6545-6cf7a4f537f0@genkgo.nl>
 <CAJd4=Ya67XaX3bwwQn20GUQqEvEVe8XEepRz9+of6h4t4fC_fg@mail.gmail.com>
 <CAPhkiZzSfwMd7TthF7jcWwY+JTnFyamyevnWDZZhGGF_qpEpKA@mail.gmail.com>
 <CAJd4=YZfMgJ7pLwUx_0GqdV+KMCGqYZFhQEDV_2KTMOKiRi6dA@mail.gmail.com>
 <CAPhkiZyHTy8m8N9f531GTMcNNhWO7Rj0U9vtMXzg3FhGyJQ0Vg@mail.gmail.com>
 <CANUQDCjam10D2SANrXQBCau8wAKQyD2gXZO7Q2fiKYQHDOhUzQ@mail.gmail.com>
 <CAJd4=YboTqF5_rUy=YhB8xNV_K=1rrkTNLg+dr1MOQrLxNmdBQ@mail.gmail.com>
 <CANUQDCjp1zMtPYX5eQmTBEdU0UmnVNiaYiXO-R9EZSztQnr4UA@mail.gmail.com>
Message-ID: <590c1490-f6d4-d796-6139-c97da933dc05@gmx.de>
Date: Sun, 22 Jul 2018 18:52:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CANUQDCjp1zMtPYX5eQmTBEdU0UmnVNiaYiXO-R9EZSztQnr4UA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [VOTE] Same Site Cookie RFC
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 22.07.2018 at 18:40, Niklas Keller wrote:

> Am So., 22. Juli 2018 um 18:11 Uhr schrieb Pedro Magalhães <mail@pmmaga.net>:
>>
>> On Sun, Jul 22, 2018 at 2:47 PM Niklas Keller <me@kelunik.com> wrote:
>>
>>> It'd be great to use an OO approach instead of "magic" array keys,
>>> e.g. like this:
>>>
>>> https://github.com/amphp/http/blob/9c0ba2f2ebfae482b3ad7a0475eb3d1f74d87949/src/Cookie/CookieAttributes.php
>>
>> While I do agree with the sentiment:
>> - That would have been an even greater departure from the original RFC.
>> - This is currently a purely procedural API. If this were about an
>> hypothetical `ResponseHeaders::setCookie` it would definitely be the way to
>> go.
>
> why does it have to be an all or nothing approach? It's perfectly fine
> to have a function that accepts an object.

We have an already accepted (29:3) RFC[1], which just lacks
implementation.  Departing from the solution, which we agreed upon, in
some details (such as suggested by Pedro) might be okay, but using
objects instead of arrays is certainly not.

[1] <https://wiki.php.net/rfc/same-site-cookie>

-- 
Christoph M. Becker