Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102954
Return-Path: <me@kelunik.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 71020 invoked from network); 22 Jul 2018 16:41:12 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 22 Jul 2018 16:41:12 -0000
Authentication-Results: pb1.pair.com smtp.mail=me@kelunik.com; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=me@kelunik.com; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.217 cause and error)
X-PHP-List-Original-Sender: me@kelunik.com
X-Host-Fingerprint: 81.169.146.217 mo4-p00-ob.smtp.rzone.de  
Received: from [81.169.146.217] ([81.169.146.217:32969] helo=mo4-p00-ob.smtp.rzone.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id E7/4E-47674-4A3B45B5 for <internals@lists.php.net>; Sun, 22 Jul 2018 12:41:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1532277666;
	s=strato-dkim-0002; d=kelunik.com;
	h=Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:
	X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender;
	bh=VHy6MbvVU/ikJsIYexMrn5byrC4fdDB6FOvTHPouVXQ=;
	b=beHgiwYAdCigiOTdI5DCJEOPlcQsyNR14dqKVrR67KFLJMA7TwrO7+PFeH21b8Gb8V
	0e/7AytXsWvuuJViPM8w0O5O71wbTtUX5U1MytZu9iCEVzRBoWG/A7Qt54Uv9e8XEexd
	uMnzV/gR5imICTidDEvf+2lONd8b41NUX5lHGqDnMMnlwAxKzemiGZouSS+Cy1f3Qss6
	1tPlQYrI5aqdNGZS6PhICc6Mc8d2+s4GfOsXeev2jEfKFaEED5QpHCBVDRjtuEg8JyzT
	Y9EjizSbBON7Er6UMZWum42UPae7iMuQ//rfzkCyvnRzaWs/lsvK7E+KjacfH9pANW3G
	J0AA==
X-RZG-AUTH: ":IWkkfkWkbvHsXQGmRYmUo9mlsGbEv0XHBzMIJSS+jKTzde5mDb8AaBUcZiAlcA=="
X-RZG-CLASS-ID: mo00
Received: by mail-yb0-f179.google.com with SMTP id s1-v6so6406542ybk.3
        for <internals@lists.php.net>; Sun, 22 Jul 2018 09:41:05 -0700 (PDT)
X-Gm-Message-State: AOUpUlGdPwB9tlZjBuOjlVV0GwXgt4zW3DlVXSlRSgoeMaR70HpIGPRG
	xWF7tIbkF3NKS7nMNXSTNQ5hqh3O2l1CfzVB6Wk=
X-Google-Smtp-Source: AAOMgpdYwc6Cg2aPfIupYwOiVcEJoepXGDQkqMXIglY2WyKxt3ayrAnPBxK6a4+TCv8oSWgCaDglgUHHQ40xdjPT9d4=
X-Received: by 2002:a25:b7d2:: with SMTP id u18-v6mr5308829ybj.448.1532277665332;
 Sun, 22 Jul 2018 09:41:05 -0700 (PDT)
MIME-Version: 1.0
References: <a4189866-23ea-4dc5-12a4-a7fbad8e5601@genkgo.nl>
 <1abd260d-ebc4-a062-3381-72485946e8bc@gmail.com> <a55b37e3-268c-f8ab-6545-6cf7a4f537f0@genkgo.nl>
 <CAJd4=Ya67XaX3bwwQn20GUQqEvEVe8XEepRz9+of6h4t4fC_fg@mail.gmail.com>
 <CAPhkiZzSfwMd7TthF7jcWwY+JTnFyamyevnWDZZhGGF_qpEpKA@mail.gmail.com>
 <CAJd4=YZfMgJ7pLwUx_0GqdV+KMCGqYZFhQEDV_2KTMOKiRi6dA@mail.gmail.com>
 <CAPhkiZyHTy8m8N9f531GTMcNNhWO7Rj0U9vtMXzg3FhGyJQ0Vg@mail.gmail.com>
 <CANUQDCjam10D2SANrXQBCau8wAKQyD2gXZO7Q2fiKYQHDOhUzQ@mail.gmail.com> <CAJd4=YboTqF5_rUy=YhB8xNV_K=1rrkTNLg+dr1MOQrLxNmdBQ@mail.gmail.com>
In-Reply-To: <CAJd4=YboTqF5_rUy=YhB8xNV_K=1rrkTNLg+dr1MOQrLxNmdBQ@mail.gmail.com>
Date: Sun, 22 Jul 2018 18:40:54 +0200
X-Gmail-Original-Message-ID: <CANUQDCjp1zMtPYX5eQmTBEdU0UmnVNiaYiXO-R9EZSztQnr4UA@mail.gmail.com>
Message-ID: <CANUQDCjp1zMtPYX5eQmTBEdU0UmnVNiaYiXO-R9EZSztQnr4UA@mail.gmail.com>
To: =?UTF-8?Q?Pedro_Magalh=C3=A3es?= <mail@pmmaga.net>
Cc: Andrey Andreev <narf@devilix.net>, Frederik Bosch <f.bosch@genkgo.nl>, 
	Stanislav Malyshev <smalyshev@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE] Same Site Cookie RFC
From: me@kelunik.com (Niklas Keller)

Am So., 22. Juli 2018 um 18:11 Uhr schrieb Pedro Magalh=C3=A3es <mail@pmmag=
a.net>:
>
> On Sun, Jul 22, 2018 at 2:47 PM Niklas Keller <me@kelunik.com> wrote:
>
> > It'd be great to use an OO approach instead of "magic" array keys,
> > e.g. like this:
> >
> > https://github.com/amphp/http/blob/9c0ba2f2ebfae482b3ad7a0475eb3d1f74d8=
7949/src/Cookie/CookieAttributes.php
> >
> > Regards, Niklas
> >
>
> Hi,
>
> While I do agree with the sentiment:
> - That would have been an even greater departure from the original RFC.
> - This is currently a purely procedural API. If this were about an
> hypothetical `ResponseHeaders::setCookie` it would definitely be the way =
to
> go.
>
> Regards,
> Pedro

Hey Pedro,

why does it have to be an all or nothing approach? It's perfectly fine
to have a function that accepts an object.

Regards, Niklas