Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102947
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NpLq4Ox8Bt2eyJqa35BoCfqNOfg0x5sy_iByARzXkrq_g@mail.gmail.com>
References: <CAFMT4NpLq4Ox8Bt2eyJqa35BoCfqNOfg0x5sy_iByARzXkrq_g@mail.gmail.com>
Date: Sun, 22 Jul 2018 10:36:28 +0200
Message-ID: <CAF+90c_esqH2xug0CxmBXLvKdBE3Eatv7CQPELyqQj8MppvMSg@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000db0f5e0571926c69"
Subject: Re: [PHP-DEV] Implementation ideas for adding early warning for
 mis-use of "parent"?
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000db0f5e0571926c69
Content-Type: text/plain; charset="UTF-8"

On Sun, Jul 22, 2018 at 2:05 AM, Levi Morrison <levim@php.net> wrote:

> This code the illustrates the issue; it has no errors or warnings:
>
> ```php
> class A {
>   function m(): parent {
>     return $this;
>   }
> }
> ```
>
> However, if you run the method you will get an error. I want to add a
> light warning such as E_STRICT or E_DEPRECATED at compile time.
>
> Using CG(active_class_entry)->parent will not work at compile time, so
> that strategy is out.
>
> Given that `zend_compile_func_decl` is not called directly from
> `zend_compile_class_decl` it would be difficult to pass the parent's
> name in any way other than a compiler global. Is there anything in
> particular I need to do if I add another compiler global? I intend to
> set and unset it in `zend_compile_class_decl`.
>
> Anyone have a better way to pass around the parent's name at compile time?
>

Please note that for traits and closures it's not possible to determine
this at compile time.

Nikita

--000000000000db0f5e0571926c69--