Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102945
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain pmmaga.net designates 149.210.149.73 as permitted sender)
MIME-Version: 1.0
References: <a4189866-23ea-4dc5-12a4-a7fbad8e5601@genkgo.nl>
 <1abd260d-ebc4-a062-3381-72485946e8bc@gmail.com> <a55b37e3-268c-f8ab-6545-6cf7a4f537f0@genkgo.nl>
 <CAJd4=Ya67XaX3bwwQn20GUQqEvEVe8XEepRz9+of6h4t4fC_fg@mail.gmail.com> <CAPhkiZzSfwMd7TthF7jcWwY+JTnFyamyevnWDZZhGGF_qpEpKA@mail.gmail.com>
In-Reply-To: <CAPhkiZzSfwMd7TthF7jcWwY+JTnFyamyevnWDZZhGGF_qpEpKA@mail.gmail.com>
Date: Sun, 22 Jul 2018 00:21:43 +0100
Message-ID: <CAJd4=YZfMgJ7pLwUx_0GqdV+KMCGqYZFhQEDV_2KTMOKiRi6dA@mail.gmail.com>
To: narf@devilix.net
Cc: f.bosch@genkgo.nl, Stanislav Malyshev <smalyshev@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000077d4c305718aad2f"
Subject: Re: [PHP-DEV] [VOTE] Same Site Cookie RFC
From: mail@pmmaga.net (=?UTF-8?Q?Pedro_Magalh=C3=A3es?=)

--00000000000077d4c305718aad2f
Content-Type: text/plain; charset="UTF-8"

On Sat, Jul 21, 2018 at 11:26 PM Andrey Andreev <narf@devilix.net> wrote:

> Yes.
>
> All other "options" are actual *cookie attribute* names, as defined by
> the various IETF RFCs, while "lifetime" is just a convenient name used
> by PHP. It doesn't correspond to a particular attribute, but instead
> the values for the Expires and Max-Age attributes are derived from it.
> I believe during discussion I insisted that the parameter be called
> "attributes", for this very reason.
>

Hi,

While I do understand your reasoning, I find it extremely unfriendly to the
user of the function to ask for one parameter separate from all the others
for that reason alone.
Also, keep in mind that all this function does is set the
`session.cookie_*` ini entries. So all parameters are treated equally.


> On another note, I also wanted that pretty much any key/value pair to
> be accepted instead of raising an error, for forward compatibility.
>

I really believe that the user spotting errors like `['expries' => time() +
3600]` faster is more valuable than FC.

Regards,
Pedro

--00000000000077d4c305718aad2f--