Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102894
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.174 as permitted sender)
MIME-Version: 1.0
References: <BY1PR02MB1260706DBB8F5E3A36A2AEF2BF580@BY1PR02MB1260.namprd02.prod.outlook.com>
 <CAF+90c_BGHBmUr1MjSXhJGhc8zJGQ67ynsn4QJhcsxo6iDWzNQ@mail.gmail.com>
 <BL0PR02MB4435EBFFEAE3BC137224BE7FAC580@BL0PR02MB4435.namprd02.prod.outlook.com>
 <27a9854c-d779-366a-5cc8-70722487139c@fedoraproject.org> <CAESVnVpvvSkevpBHdza34fnxK23ZvMfD25-o4cNTtduNAEQPig@mail.gmail.com>
 <CAJHtznyR9u7i97JY=A6ZOmvis08SSbOzkxrn5FdZn7BUm-Le_w@mail.gmail.com>
 <CAF+90c9=a+4J7UxDWPjJKE8E0RPixfy3JLPpOdeWVZi-7yUMnA@mail.gmail.com>
 <CAJHtznyeGxy9QQzjPRoqFdhT2xxrtosP9dgQQu63xn0gc4wxfg@mail.gmail.com> <CAF+90c-EZ-N+GLmXP5OO19zKVtmiZvxiv_vgaY=iiho1mFa7fw@mail.gmail.com>
In-Reply-To: <CAF+90c-EZ-N+GLmXP5OO19zKVtmiZvxiv_vgaY=iiho1mFa7fw@mail.gmail.com>
Date: Tue, 17 Jul 2018 20:06:14 +0300
Message-ID: <CAJHtznwP35HZBbuv-4gmw4kjrQD6LvqPFKW0jPtVzA8GyhZbZg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Sara Golemon <pollita@php.net>, remi@fedoraproject.org, 
	Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000061a155057134f7ba"
Subject: Re: [PHP-DEV] re2c version(s)
From: vsuraski@gmail.com (Zeev Suraski)

--00000000000061a155057134f7ba
Content-Type: text/plain; charset="UTF-8"

On Tue, Jul 17, 2018 at 7:57 PM Nikita Popov <nikita.ppv@gmail.com> wrote:

>
> Ah yes, *of course* the generated files will be part of distribution
> tarballs, just like we do with all generated files (not just the parser,
> but also configure.) While I forgot to write this in my original mail, it
> has been mentioned already 4 days ago. So again, it seems like we're really
> in total agreement here, just a matter of turning it into reality ;)
>

You know, you made me go back to Sara's email where she disagreed with me,
only to find she actually was disagreeing with Remi's proposal to track the
generated files for releases in git.  That's definitely not a hill to die
on for me :)

So all in all I think you're right, we agree on the important things:
1. Remove generated files from git
2. Keep them in source packages

What we seem to disagree on is that we should have a narrower list of
acceptable re2c versions determined by configure/makedist.  This isn't a
hill to die on for me either, although I think that narrowing it down is
better in terms of our ability to deliver a source package with confidence,
and be sure that everyone who's testing/using it is testing the same thing
(similar to how we do it with bison).  Arguably it's more important to be
on the safe wide with makedist than it is with configure.

Thanks,

Zeev

--00000000000061a155057134f7ba--