Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102893
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJHtznyeGxy9QQzjPRoqFdhT2xxrtosP9dgQQu63xn0gc4wxfg@mail.gmail.com>
References: <BY1PR02MB1260706DBB8F5E3A36A2AEF2BF580@BY1PR02MB1260.namprd02.prod.outlook.com>
 <CAF+90c_BGHBmUr1MjSXhJGhc8zJGQ67ynsn4QJhcsxo6iDWzNQ@mail.gmail.com>
 <BL0PR02MB4435EBFFEAE3BC137224BE7FAC580@BL0PR02MB4435.namprd02.prod.outlook.com>
 <27a9854c-d779-366a-5cc8-70722487139c@fedoraproject.org> <CAESVnVpvvSkevpBHdza34fnxK23ZvMfD25-o4cNTtduNAEQPig@mail.gmail.com>
 <CAJHtznyR9u7i97JY=A6ZOmvis08SSbOzkxrn5FdZn7BUm-Le_w@mail.gmail.com>
 <CAF+90c9=a+4J7UxDWPjJKE8E0RPixfy3JLPpOdeWVZi-7yUMnA@mail.gmail.com> <CAJHtznyeGxy9QQzjPRoqFdhT2xxrtosP9dgQQu63xn0gc4wxfg@mail.gmail.com>
Date: Tue, 17 Jul 2018 18:57:46 +0200
Message-ID: <CAF+90c-EZ-N+GLmXP5OO19zKVtmiZvxiv_vgaY=iiho1mFa7fw@mail.gmail.com>
To: Zeev Suraski <vsuraski@gmail.com>
Cc: Sara Golemon <pollita@php.net>, Remi Collet <remi@fedoraproject.org>, 
	Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000072b632057134d8c1"
Subject: Re: [PHP-DEV] re2c version(s)
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000072b632057134d8c1
Content-Type: text/plain; charset="UTF-8"

On Tue, Jul 17, 2018 at 6:41 PM, Zeev Suraski <vsuraski@gmail.com> wrote:

> On Tue, Jul 17, 2018 at 6:05 PM Nikita Popov <nikita.ppv@gmail.com> wrote:
>
>> I feel like we are all really in violent agreement that these files
>> should be dropped from git, and at this point I'm not even sure what the
>> discussion is about anymore. Let's wait until after PHP-7.3 branching in
>> two weeks and drop them at that point.
>>
>> Normalizing the version numbers seems unnecessary after they are dropped
>> -- at least Dmitry's original motivation for that was related exclusively
>> to the spurious diffs caused by different versions, which will no longer be
>> an issue.
>>
>
> While we all agree that the files should be dropped from git - there
> appears to be disagreement regarding what else we need to do in addition.
> In my opinion if that's the only action we'd take then I don't think we
> should do it and the status quo is actually better - as it would mean that
> it will no longer be possible to build our packages in platforms that don't
> have re2c available or typically installed.  It needs to happen hand in
> hand with providing these files in the source packages, and also ensuring
> that whatever boxes one uses to create the packages - as well as developers
> who check out the source code directly from git - have an acceptable
> version of re2c.  It may be that we can accept a wide range of re2c
> versions (although if there are substantial differences in code perhaps
> it's better to err on the side of caution).
>
> I'm not sure why we're not simply following exactly what we're doing with
> the parser.  We have a list of acceptable bison versions.  We check both in
> configure and makedist against that list, and refuse to generate the parser
> otherwise.  We don't track the generated .c file in source control - but we
> do include it in distros to account for environments that don't typically
> have bison installed.  Why not do exactly the same with the re2c scanner?
>

Ah yes, *of course* the generated files will be part of distribution
tarballs, just like we do with all generated files (not just the parser,
but also configure.) While I forgot to write this in my original mail, it
has been mentioned already 4 days ago. So again, it seems like we're really
in total agreement here, just a matter of turning it into reality ;)

Nikita

--00000000000072b632057134d8c1--