Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102886
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.48 as permitted sender)
MIME-Version: 1.0
References: <CAKOZhE8c6L3bTFtne7MPTH0Qf3kfKYYnby71uSUEU75EsfAbgA@mail.gmail.com>
 <CA+kxMuTaW3eiWgPGu93xZti7vnGQiqg59_qkHGis8bh7Et96Gg@mail.gmail.com>
In-Reply-To: <CA+kxMuTaW3eiWgPGu93xZti7vnGQiqg59_qkHGis8bh7Et96Gg@mail.gmail.com>
Date: Tue, 17 Jul 2018 14:08:39 +0200
Message-ID: <CAKOZhE_L-c_vTQiMVPrbc=R7+LEfxQ8P-eRVcN1MN3NC6B2bPw@mail.gmail.com>
To: danack@basereality.com
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000001e55f2057130cf21"
Subject: Re: [PHP-DEV] [RFC] Optional typehint check for parameters
From: mitke013@gmail.com (Zeljko Mitic)

--0000000000001e55f2057130cf21
Content-Type: text/plain; charset="UTF-8"

On Tue, Jul 17, 2018 at 1:18 PM Dan Ackroyd <danack@basereality.com> wrote:

> On 15 July 2018 at 20:39, Zeljko Mitic <mitke013@gmail.com> wrote:
> > PHP is dynamic language and each typed typehinted parameter has to be
> > checked every time.
>
> If you think your code would benefit appreciably from having parameter
> types removed, I would strongly recommend looking at
> https://preprocess.io/ and similar libraries.
>
> Preprocessing is used in Javascript to quite radically change what is
> possible to code in 'Javascript' and has allowed rapid development in
> how 'Javascript' can be used. For example JSX is something that would
> never have been approved by the ECMA committee.....but because it was
> implemented a preprocessing step it never needed to be approved before
> could get wide-scale usage.
>
> cheers
> Dan
> Ack
>

It won't help, preprocess.io doesn't remove typehints.  But this is mostly
intended for other features like generics/typed arrays for which I have
read that speed is a big blocker.

Anyway, if anyone is interested, I did some testing on parameter check. The
code:
---
class Customer {}

function test(Customer $customer) {}

$customer = new Customer();
$start = microtime(true);

for ($i=1;$i<100000000;$i++) {  // 100 million
    test($customer);
}

echo microtime(true) - $start;
---

Tested 3 times, average time: 3.58s

When I removed typehint from test() function, average time was: 2.76s

Difference is 29.7%

I know it is unrealistic scenario because there is nothing else in the
code, I was just curios.

--0000000000001e55f2057130cf21--