Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102885
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.169 as permitted sender)
MIME-Version: 1.0
References: <BY1PR02MB1260706DBB8F5E3A36A2AEF2BF580@BY1PR02MB1260.namprd02.prod.outlook.com>
 <CAF+90c_BGHBmUr1MjSXhJGhc8zJGQ67ynsn4QJhcsxo6iDWzNQ@mail.gmail.com>
 <BL0PR02MB4435EBFFEAE3BC137224BE7FAC580@BL0PR02MB4435.namprd02.prod.outlook.com>
 <27a9854c-d779-366a-5cc8-70722487139c@fedoraproject.org> <CAESVnVpvvSkevpBHdza34fnxK23ZvMfD25-o4cNTtduNAEQPig@mail.gmail.com>
In-Reply-To: <CAESVnVpvvSkevpBHdza34fnxK23ZvMfD25-o4cNTtduNAEQPig@mail.gmail.com>
Date: Tue, 17 Jul 2018 14:51:57 +0300
Message-ID: <CAJHtznyR9u7i97JY=A6ZOmvis08SSbOzkxrn5FdZn7BUm-Le_w@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: remi@fedoraproject.org, Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005a9fda0571309355"
Subject: Re: [PHP-DEV] re2c version(s)
From: vsuraski@gmail.com (Zeev Suraski)

--0000000000005a9fda0571309355
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 17, 2018 at 2:01 PM Sara Golemon <pollita@php.net> wrote:

> On Tue, Jul 17, 2018 at 1:04 AM, Remi Collet <remi@fedoraproject.org>
> wrote:
> > Le 13/07/2018 =C3=A0 23:48, Zeev Suraski a =C3=A9crit :
> > Perhaps we can also add all the generated files (including configure) i=
n
> > the tagged versions, so the tag will have same content than the officia=
l
> > archive.
> >
> Ick, no.  That's the worst outcome IMO.  I don't think they need to be
> in git, but if we're going to have them there during tags, then they
> should always be there.  One way or the other, not some
> middle-of-the-road thing.


I can explain why I think that what I propose is the best outcome:
- It ensures that the correct versions of re2c are always used.
- It doesn't track generated files in source control.
- It allows users to build PHP from source on platforms where re2c is
unavailable.

Correct me if I'm wrong, but isn't that exactly what we do with
zend_language_parser.c?  makedist is responsible for generating it so that
it's available in distributions, but it isn't tracked.  Why would
zend_language_scanner.c be any different?  My guess is that it's probably
because at the time we moved to re2c it wasn't nearly as ubiquitous as it
is today and even most developers didn't have access to it, but now that's
changed.

I'm also fine with what Remi proposed which is adding these files
specifically to the source control at the time of tagging, in the spirit of
tracking everything that we actually end up releasing in source control
(and perhaps do that for zend_language_parser.c if we decide that this is
the right thing to do).

Either way - the first step (normalizing re2c versions - updating our r2ec
requirements) seems to make sense.  We can decide about whether or not we
track the generated files in git as we do today, only during tagging or not
at all independently of that.

Zeev

--0000000000005a9fda0571309355--