Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102829
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender)
MIME-Version: 1.0
References: <e8fdd7ca-135a-2a7f-79cd-e45486f4ba8b@web.de> <tencent_3910FA2861CB2DDC6DBA9FF9@qq.com>
 <59.92.57182.80D864B5@pb1.pair.com>
In-Reply-To: <59.92.57182.80D864B5@pb1.pair.com>
Date: Sun, 15 Jul 2018 10:24:16 +0900
Message-ID: <CAGa2bXZxLCeviyKGRHZCipOMUvjX020cHRPw7Q=C6xe6pnE8+Q@mail.gmail.com>
To: Andrew Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007079c80570ff9493"
Subject: Re: [PHP-DEV] [VOTE] array_key_first(), array_key_last(), array_value_first(),array_value_last()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--0000000000007079c80570ff9493
Content-Type: text/plain; charset="UTF-8"

On Thu, Jul 12, 2018 at 8:05 AM Andrea Faulds <ajf@ajf.me> wrote:

> Hi,
>
> CHU Zhaowei wrote:
> > I voted no.
> > I don't think we have an agreement on dealing with non-existing value,
> and the way this RFC proposed, just returning null without any
> notice/warning, is wrong IMO. I know we already do this in other array_*
> functions, but we cannot keep making mistakes just because we already made
> same mistake.
> >
> > Regards,
> > CHU Zhaowei
> >
>

Since PHP supports null coalesce, it makes sense applying null coalesce by
default.
Many users do it for inputs. e.g $var = $_GET['var'] ?? null;


>
> Hmm. Returning null with no warning makes perfect sense for keys, since
> null is not a valid key so there's no ambiguity, but for values it seems
> problematic. On that ground I've decided to change my vote to No for the
> value functions, but keep the vote for Yes for the key functions.
> Someone who wants such behaviour could always do
> ($array[array_key_last($array)] ?? null), I guess.
>

When array_value_last($array) is needed, users would want null coalesce
almost always.
When user don't want it, they can

if (array_key_last($array) === NULL) { // Or if (!count($array)) {
  die("hey, no value defined");
}
$var = array_value_last($array);

This usage would be rare and use of ($array[array_key_last($array)] ??
null) for null coalesce is pain.
It lacks API consistency as well.
Therefore, I voted "yes" for both.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--0000000000007079c80570ff9493--