Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:102810
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.208.52 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <AM6PR0502MB3848BF9FD3A7B589A9378781BA580@AM6PR0502MB3848.eurprd05.prod.outlook.com>
References: <BY1PR02MB1260706DBB8F5E3A36A2AEF2BF580@BY1PR02MB1260.namprd02.prod.outlook.com>
 <CAF+90c_BGHBmUr1MjSXhJGhc8zJGQ67ynsn4QJhcsxo6iDWzNQ@mail.gmail.com>
 <BY1PR02MB1260229D19B14B069E2B66DDBF580@BY1PR02MB1260.namprd02.prod.outlook.com>
 <CAESVnVpqhSO8AJkzuwihgPPknr7HvWmS6EVc=n+QaqDBj7pwcQ@mail.gmail.com> <AM6PR0502MB3848BF9FD3A7B589A9378781BA580@AM6PR0502MB3848.eurprd05.prod.outlook.com>
Date: Fri, 13 Jul 2018 16:27:24 -0400
Message-ID: <CAESVnVqKiAq6Lv_tSEDbBWKjBQV5D4Q4135a3PshXyq-sSnLSQ@mail.gmail.com>
To: Anatol Belski <ab@php.net>
Cc: Dmitry Stogov <dmitry@zend.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals list <internals@lists.php.net>, Stanislav Malyshev <smalyshev@gmail.com>, 
	"derick@derickrethans.nl" <derick@derickrethans.nl>, "Christoph M. Becker" <cmbecker69@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] re2c version(s)
From: pollita@php.net (Sara Golemon)

On Fri, Jul 13, 2018 at 3:08 PM, Anatol Belski <ab@php.net> wrote:
>> I ask, because my release builder for 7.2 (and 7.1 if Joe is using
>> Davey's builder) is using re2c 0.13.5 .   I don't imagine the risk of
>> updating re2c mid-relase is particularly high, but it is non-zero.
>>
> Normally RMs would define the tool versions that are expected
> to be stable and that are always used for the official tarballs.
> In the case of 7.0, it'd be always re2c 0.13.5 and bison 3.0.2,
> where ever I'd produce the tarball (even I don't always use
> Jessie for packaging). We probably should take this into the
> release process docs, if it isn't there already.
>
Well, whichever version we've settled on, I've updated
sgolemon/php-release to allow using arbitrary versions of re2c.
https://github.com/sgolemon/php-release/commit/9197257bc6f2f607476f950733a0c13ab5e3e867

If RE2C_VERSION is set to 1.0.3, it'll swap in the pre-built 1.0.3
binary I've included in the package.
Otherwise, it'll clone the source repo, checkout the requested tag (or
commit hash) and build that).

I'll plan on doing 7.2.9+ with 1.0.3 (unless we decide differently by then).
Remi should stick to 0.13.5 (default) for 7.2.8-final as previously stated.
Doing a dry-run now to see how it looks.

-Sara